Bug 48229 - Replace _countof with WTF_ARRAY_LENGTH
: Replace _countof with WTF_ARRAY_LENGTH
Status: RESOLVED FIXED
: WebKit
Web Template Framework
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-10-25 05:01 PST by
Modified: 2010-10-25 10:03 PST (History)


Attachments
Patch (14.60 KB, patch)
2010-10-25 05:10 PST, Patrick R. Gansterer
no flags Review Patch | Details | Formatted Diff | Diff
Patch (14.60 KB, patch)
2010-10-25 05:14 PST, Patrick R. Gansterer
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-10-25 05:01:58 PST
see patch
------- Comment #1 From 2010-10-25 05:10:08 PST -------
Created an attachment (id=71736) [details]
Patch
------- Comment #2 From 2010-10-25 05:13:02 PST -------
Attachment 71736 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/plugins/win/PluginDatabaseWin.cpp:409:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2010-10-25 05:14:58 PST -------
Created an attachment (id=71737) [details]
Patch

Fix style
------- Comment #4 From 2010-10-25 09:10:49 PST -------
(From update of attachment 71737 [details])
r=me

I assume that assigning to the DWORD type doesn't require a cast on Windows [CE].
------- Comment #5 From 2010-10-25 10:03:46 PST -------
(From update of attachment 71737 [details])
Clearing flags on attachment: 71737

Committed r70460: <http://trac.webkit.org/changeset/70460>
------- Comment #6 From 2010-10-25 10:03:51 PST -------
All reviewed patches have been landed.  Closing bug.