Bug 48228 - Use WTF::StringHasher::createBlobHash where possible
Summary: Use WTF::StringHasher::createBlobHash where possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-25 04:42 PDT by Patrick R. Gansterer
Modified: 2010-11-01 10:10 PDT (History)
1 user (show)

See Also:

Attachments
Patch (11.87 KB, patch)
2010-10-25 04:54 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Stack trace of recent GTK+ assertion failures (56.63 KB, text/html)
2010-11-01 08:49 PDT, Martin Robinson 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-10-25 04:42:43 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-10-25 04:54:44 PDT 
Created attachment 71733 [details]
Patch
Comment 2 Adam Barth 2010-10-27 13:07:20 PDT 
Comment on attachment 71733 [details]
Patch

Quite nice.  Thanks.
Comment 3 WebKit Commit Bot 2010-10-27 14:05:44 PDT 
Comment on attachment 71733 [details]
Patch

Clearing flags on attachment: 71733

Committed r70705: <http://trac.webkit.org/changeset/70705>
Comment 4 WebKit Commit Bot 2010-10-27 14:05:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Martin Robinson 2010-11-01 08:48:47 PDT 
Since this patch landed the 64-bit GTK+ Debug bot has had random assertion failures in the FontCache code and general flakiness with respect to layout test font metrics. I think this patch might be the culprit. I've attached a stack trace of one of these failures.
Comment 6 Martin Robinson 2010-11-01 08:49:37 PDT 
Created attachment 72512 [details]
Stack trace of recent GTK+ assertion failures
Comment 7 Patrick R. Gansterer 2010-11-01 10:10:08 PDT 
(In reply to comment #6)
> Created an attachment (id=72512) [details]
> Stack trace of recent GTK+ assertion failures

Is "ASSERT(!lookupForWriting(Extractor::extract(entry)).second)" the assertion you reach? Do you see any code which changed behavior in this patch? Is this the only bug in the blame list?