Bug 48226 – Web Inspector: display cookies associated with request

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

Provide a tab in resource view with a list of cookies if Cookie/Set-Cookie headers are available.

[Andrey Kosyakov]

Created attachment 71723 [details]
patch

[WebKit Review Bot]

Attachment 71723 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/front-end/ResourceCookiesView.js:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebCore/inspector/front-end/CookieItemsViewBase.js:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 251 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andrey Kosyakov]

Created attachment 71731 [details]
screenshot

[Andrey Kosyakov]

Created attachment 71732 [details]
patch

- Fixed "disclosure" flag on name column
- Fixed EOLs

[Andrey Kosyakov]

Created attachment 71735 [details]
patch

- Fixed resize() not being called sometimes
- Fixed cookies being shown in Sources Panel

[Timothy Hatcher]

This looks nice. But they why re some of the column dividers 1px off from the header dividers? Also should size have a "B" unit?

[Timothy Hatcher]

THE HTTP and Secure columns can be smaller.

[Andrey Kosyakov]

(In reply to comment #7)

> This looks nice. But they why re some of the column dividers 1px off from the header dividers? 

My bad, that was a bug with DataGrid.updateWidths() not being called, fixed it since then.

> Also should size have a "B" unit?

This was on purpose -- I thought that given cookies are supposed to be under few KB, it would be a good idea not to use bytesToString() -- first, to make large cookie stand out visually by having a large number in table, but also to reduce clutter due to "B" being everywhere. I realize we could be doing this for consistency with other places, though, so I'll bring bytesToString() back if you say so.

> THE HTTP and Secure columns can be smaller.

As it transpired, DataGrid.autoSizeColumns() was only taking top-level rows into account. Fixed that and relaxed min/max width limits -- I think it looks better now.

[Andrey Kosyakov]

Created attachment 71759 [details]
updated screenshot

- Fixed table header/body width inconsistency
- Fixed autosize

[Andrey Kosyakov]

Created attachment 71760 [details]
patch

- Take children into consideration when computing table width

[WebKit Review Bot]

Attachment 71759 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

Comment on attachment 71760 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71760&action=review

> WebCore/ChangeLog:64
> [phone]  Andrey Kosyakov  <[e-mail]>

Two changelogs.

> WebCore/WebCore.gypi:4424
> +            'inspector/front-end/ResourceCookiesView.js',

This is a tab, not a view.

> WebCore/inspector/front-end/CookieItemsViewBase.js:33
> +WebInspector.CookieItemsViewBase = function()

This could simply reside in CookieItemsView in form of helper methods / component.

> WebCore/inspector/front-end/CookieParser.js:57
> +                this._addCookie(kv, "request");

Could you use constants for these?

> WebCore/inspector/front-end/DataGrid.js:320
> +        var children = maxDescentLevel ? this._enumerateChildren(this, [], maxDescentLevel) : this.children;

So if I pass "1" as maxDescentLevel, the code will work as if it was "1".

> WebCore/inspector/front-end/DataGrid.js:404
> +        if (!this._columnWidthsInitialized && this.element.enclosingNodeOrSelfWithNodeName("body")) {

You could also check this.element.offsetWidth for === 0.

[Alexey Proskuryakov]

> Provide a tab in resource view with a list of cookies if Cookie/Set-Cookie headers are available.

How is this different from bug 16531?

[Andrey Kosyakov]

*** This bug has been marked as a duplicate of bug 16531 ***