Bug 48219 - Expose HitTestResult::absoluteMediaURL() via WebKit API
Summary: Expose HitTestResult::absoluteMediaURL() via WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-24 19:13 PDT by mitz
Modified: 2010-10-24 22:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.76 KB, patch)
2010-10-24 19:37 PDT, mitz 		no flags Details | Formatted Diff | Diff
Patch (7.20 KB, patch)
2010-10-24 20:17 PDT, mitz 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2010-10-24 19:13:58 PDT 
Expose HitTestResult::absoluteMediaURL() via WebKit API
Comment 1 mitz 2010-10-24 19:37:13 PDT 
Created attachment 71709 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-24 19:39:38 PDT 
Attachment 71709 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/win/WebElementPropertyBag.cpp:165:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebKit/mac/WebView/WebViewPrivate.h:70:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2010-10-24 20:17:48 PDT 
Created attachment 71711 [details]
Patch

Export the key from WebKit.
Comment 4 WebKit Review Bot 2010-10-24 20:20:30 PDT 
Attachment 71711 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/win/WebElementPropertyBag.cpp:165:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebKit/mac/WebView/WebViewPrivate.h:70:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 mitz 2010-10-24 22:18:21 PDT 
Committed <trac.webkit.org/changeset/70435>.