Bug 48215 - SVGTextElement supplemental transforms pre-multiplied but should be post-multiplied in animatedLocalTransform
Summary: SVGTextElement supplemental transforms pre-multiplied but should be post-mult...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Shane Stephens
URL:
Keywords:
Depends on:
Blocks: 48031
  Show dependency tree / graph
 
Reported: 2010-10-24 17:09 PDT by Shane Stephens
Modified: 2011-01-18 22:16 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.33 KB, patch)
2010-10-24 17:14 PDT, Shane Stephens 		no flags Details | Formatted Diff | Diff
Patch (6.36 KB, patch)
2010-11-09 11:58 PST, Shane Stephens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shane Stephens 2010-10-24 17:09:34 PDT 
SVGTextElement supplemental transforms pre-multiplied but should be post-multiplied in animatedLocalTransform
Comment 1 Shane Stephens 2010-10-24 17:14:43 PDT 
Created attachment 71701 [details]
Patch
Comment 2 Dirk Schulze 2010-10-26 23:13:56 PDT 
Comment on attachment 71701 [details]
Patch

Does this only apply to elements with local transform in combination of animateMotion, what about animateTransform? If you need animation tests, you should use the animation test api in svg/animations. Please take a look there. Using setTimeout is definitely wrong.
If it does not only effect animateMotion, I'd like to see more tests.
Comment 3 Shane Stephens 2010-11-09 11:58:45 PST 
Created attachment 73396 [details]
Patch
Comment 4 Dirk Schulze 2010-11-09 23:45:33 PST 
Comment on attachment 73396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73396&action=review

r=me

> WebCore/ChangeLog:17
> +        Switched order of multiplication.  Note that due to a bug in 
> +        AffineTransform's operator* implementation the order of arguments is
> +        reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031).
> +

Please add a comment that this will be fixed in a followup.
Comment 5 Nikolas Zimmermann 2010-11-10 00:25:52 PST 
Comment on attachment 73396 [details]
Patch

My next patch depends on this fix, setting cq+ to get it in ASAP.
Comment 6 WebKit Commit Bot 2010-11-10 01:01:44 PST 
The commit-queue encountered the following flaky tests while processing attachment 73396 [details]:

http/tests/appcache/reload.html

Please file bugs against the tests.  The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2010-11-10 01:04:29 PST 
Comment on attachment 73396 [details]
Patch

Clearing flags on attachment: 73396

Committed r71726: <http://trac.webkit.org/changeset/71726>
Comment 8 WebKit Commit Bot 2010-11-10 01:04:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2010-11-10 01:25:35 PST 
http://trac.webkit.org/changeset/71726 might have broken Qt Linux Release
The following tests are not passing:
svg/animations/animate-text-nested-transforms.html
Comment 10 Nikolas Zimmermann 2010-11-10 02:10:25 PST 
(In reply to comment #9)
> http://trac.webkit.org/changeset/71726 might have broken Qt Linux Release
> The following tests are not passing:
> svg/animations/animate-text-nested-transforms.html

Same problem as bug 49045.