This function iterates over a QImage getting and setting every pixel with pixel() and setPixel(). This is ridiculously slow since it does bounds checking and detach() for every pixel. We should grab the bits() and do direct access.
Created attachment 71697 [details] Proposed patch
Comment on attachment 71697 [details] Proposed patch Looks fine. Where did you run into this issue?
(In reply to comment #2) > (From update of attachment 71697 [details]) > Looks fine. Where did you run into this issue? The SVG folks were discussing http://svg-wow.org/filterEffects/chiseled.svg so I gave it a spin in QtTestBrowser. I should have included that in the bug description, sorry. Thanks for reviewing! <3
Comment on attachment 71697 [details] Proposed patch Clearing flags on attachment: 71697 Committed r70424: <http://trac.webkit.org/changeset/70424>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/70424 might have broken Leopard Intel Debug (Tests) The following tests are not passing: editing/spelling/context-menu-suggestions.html editing/spelling/spellcheck-attribute.html editing/spelling/spelling-backspace-between-lines.html editing/spelling/spelling-contenteditable.html editing/spelling/spelling-textarea.html platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html platform/mac/accessibility/misspelled-attributed-string.html