Bug 48207 - Web Inspector: slowly make old resources panel optional.
Summary: Web Inspector: slowly make old resources panel optional.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on: 48206
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-24 08:38 PDT by Pavel Feldman
Modified: 2010-10-25 09:01 PDT (History)
10 users (show)

See Also:


Attachments
[PATCH] Proposed change. (18.67 KB, patch)
2010-10-24 08:47 PDT, Pavel Feldman
timothy: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
[IMAGE] Screenshot while running with patch (Resources panel). (127.39 KB, image/png)
2010-10-24 08:48 PDT, Pavel Feldman
no flags Details
[IMAGE] Screenshot while running with patch (Network panel). (227.17 KB, image/png)
2010-10-24 08:49 PDT, Pavel Feldman
no flags Details
[IMAGE] Screenshot while running with patch (Resources panel). (162.67 KB, image/png)
2010-10-24 08:51 PDT, Pavel Feldman
no flags Details
[PATCH] Follow up addressing review comments. (7.17 KB, patch)
2010-10-25 08:17 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff
[IMAGE] Screenshot while running with patch. (157.92 KB, image/png)
2010-10-25 08:21 PDT, Pavel Feldman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-10-24 08:38:43 PDT
Patch to follow.
Comment 1 Pavel Feldman 2010-10-24 08:47:38 PDT
Created attachment 71684 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-10-24 08:48:31 PDT
Created attachment 71685 [details]
[IMAGE] Screenshot while running with patch (Resources panel).
Comment 3 Pavel Feldman 2010-10-24 08:49:10 PDT
Created attachment 71686 [details]
[IMAGE] Screenshot while running with patch (Network panel).
Comment 4 Pavel Feldman 2010-10-24 08:51:11 PDT
Created attachment 71687 [details]
[IMAGE] Screenshot while running with patch (Resources panel).
Comment 5 Timothy Hatcher 2010-10-24 10:52:16 PDT
Comment on attachment 71684 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=71684&action=review

> WebCore/ChangeLog:34
> +        Web Inspector: add support for errors, warnings and search to the storage panel.

Double ChangeLog.

> WebCore/inspector/front-end/inspector.js:-233
> -        if (hiddenPanels.indexOf("scripts") === -1)

Why remove the hidden panels stuff? I think this si used by some OS X WebKit clients.

> WebCore/inspector/front-end/inspector.js:1690
> +    if (WebInspector.resourceManager) {

Add a newline before this one.
Comment 6 Timothy Hatcher 2010-10-24 10:53:50 PDT
I'd like to see the divider column in the new Resources panel be 1px like the other divider lines.
Comment 7 Timothy Hatcher 2010-10-24 10:59:57 PDT
Also the "&utmac…" resource has the wrong name. It should be "__utm.gif", which is what it is in shipping Safari. We should not show query strings in/as the file name.
Comment 8 Pavel Feldman 2010-10-25 02:51:27 PDT
(In reply to comment #6)
> I'd like to see the divider column in the new Resources panel be 1px like the other divider lines.

Will address comments in a separate patch since am in a hurry landing this one - accidentally enabled network panel in the previous commit...

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/AuditsPanel.js
	M	WebCore/inspector/front-end/ExtensionServer.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/inspector.js
Committed r70446
Comment 9 Pavel Feldman 2010-10-25 08:17:25 PDT
Created attachment 71751 [details]
[PATCH] Follow up addressing review comments.
Comment 10 Pavel Feldman 2010-10-25 08:21:11 PDT
Created attachment 71752 [details]
[IMAGE] Screenshot while running with patch.
Comment 11 Timothy Hatcher 2010-10-25 08:28:02 PDT
Comment on attachment 71751 [details]
[PATCH] Follow up addressing review comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=71751&action=review

> WebCore/inspector/front-end/StoragePanel.js:578
> +            return false; // Should never get here.

console.error here too?

> WebCore/inspector/front-end/StoragePanel.js:583
> +            return null; // Should never get here.

console.error here too?
Comment 12 Pavel Feldman 2010-10-25 09:01:57 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/Resource.js
	M	WebCore/inspector/front-end/StoragePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r70454