Bug 48197 - Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback()
Summary: Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback()
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
Depends on:
Reported: 2010-10-23 17:47 PDT by Daniel Bates
Modified: 2010-10-23 19:19 PDT (History)
3 users (show)

See Also:

Patch (2.10 KB, patch)
2010-10-23 18:02 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-10-23 17:47:24 PDT
We should remove the method HTMLFrameElementBase::setNameAndOpenURLCallback() since it is unused.

For completeness, this method was added in changeset 24396 <http://trac.webkit.org/changeset/24396> and had one call site in HTMLFrameElementBase::attach().
This call site was removed in changeset 67182 <http://trac.webkit.org/changeset/67182>.
Comment 1 Daniel Bates 2010-10-23 18:02:20 PDT
Created attachment 71662 [details]

No functionality was changed. So, no new tests.
Comment 2 WebKit Commit Bot 2010-10-23 19:19:06 PDT
The commit-queue encountered the following flaky tests while processing attachment 71662 [details]:


Please file bugs against the tests.  The author(s) of the test(s) are jchaffraix@webkit.org.  The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2010-10-23 19:19:46 PDT
Comment on attachment 71662 [details]

Clearing flags on attachment: 71662

Committed r70407: <http://trac.webkit.org/changeset/70407>
Comment 4 WebKit Commit Bot 2010-10-23 19:19:51 PDT
All reviewed patches have been landed.  Closing bug.