Bug 48187 - webkit-patch upload fails when the patch removes a file
Summary: webkit-patch upload fails when the patch removes a file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 48272
  Show dependency tree / graph
 
Reported: 2010-10-23 08:36 PDT by David Kilzer (:ddkilzer)
Modified: 2010-10-25 15:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2010-10-24 20:51 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2010-10-23 08:36:43 PDT 
When webkit-patch upload attempts to process a patch that removes a file (for Bug 48186), it fails:

$ ./WebKitTools/Scripts/webkit-patch upload -m "Patch v1" --open-bug --suggest-reviewers -g HEAD 48186
Running check-webkit-style
Total errors found: 0 in 4 files
3 files to edit
Was that diff correct? [Y/n]: y
Fetching: https://bugs.webkit.org/show_bug.cgi?id=48186&ctype=xml
Failed to run "[u'git', u'log', u'--pretty=format:%H', u'-5', u'/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h']" exit_code: 128
fatal: ambiguous argument '/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions

Failed to run "[u'git', u'log', u'--pretty=format:%H', u'-5', u'/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h']" exit_code: 128
Comment 1 Adam Barth 2010-10-23 09:35:40 PDT 
Thanks for the report.  We need to add -- before the file names.
Comment 2 Adam Barth 2010-10-24 20:51:25 PDT 
Created attachment 71713 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2010-10-24 21:10:01 PDT 
Comment on attachment 71713 [details]
Patch

Thanks!  r=me
Comment 4 WebKit Commit Bot 2010-10-24 22:30:39 PDT 
Comment on attachment 71713 [details]
Patch

Clearing flags on attachment: 71713

Committed r70437: <http://trac.webkit.org/changeset/70437>
Comment 5 WebKit Commit Bot 2010-10-24 22:30:45 PDT 
All reviewed patches have been landed.  Closing bug.