Bug 48172 - check-webkit-style script should be changed for WebKit2
Summary: check-webkit-style script should be changed for WebKit2
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 37369
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-22 23:24 PDT by Amruth Raj
Modified: 2010-10-23 07:15 PDT (History)
1 user (show)

See Also:

Attachments
Filtering files which have followed GTK naming convention (2.13 KB, patch)
2010-10-22 23:27 PDT, Amruth Raj 		ddkilzer: review-
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amruth Raj 2010-10-22 23:24:35 PDT 
Following changes are required for the check-webkit-style script for WebKit2:

1. config.h need not be the first header inclusion in WebKit2 files as we are following framework style inclusion

2. WebKit2/UIProcess/gtk/WebViewInternal.h and WebKit2/UIProcess/gtk/WebViewInternal.cpp should be allowed to follow GTK naming conventions.
This depends on https://bugs.webkit.org/show_bug.cgi?id=37369
Added a patch for the same.
Comment 1 Amruth Raj 2010-10-22 23:27:22 PDT 
Created attachment 71623 [details]
Filtering files which have followed GTK naming convention

Filtering files which have followed GTK naming convention from checker.py
Comment 2 David Kilzer (:ddkilzer) 2010-10-23 07:14:59 PDT 
Comment on attachment 71623 [details]
Filtering files which have followed GTK naming convention

View in context: https://bugs.webkit.org/attachment.cgi?id=71623&action=review

r- to fix the ChangeLog.  Otherwise this looks fine.

> WebKitTools/ChangeLog:1
> +2010-10-22  Amruth Raj/Ravi Kasibhatla  <amruthraj@motorola.com/ravi.kasibhatla@motorola.com>

Please reformat authors and email addresses:

2010-10-22  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>

> WebKitTools/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Adding the WebKit2/UIProcess/gtk as a exception for style checking.
> +        The folder has two files WebViewInternal.h and WebViewInternal.cpp
> +        which follow GTK naming convention.

Please add the bug title and a link to the bug in the ChangeLog.