Bug 48171 - EWS never releases patches which fail to apply
Summary: EWS never releases patches which fail to apply
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 35460
  Show dependency tree / graph
 
Reported: 2010-10-22 23:03 PDT by Eric Seidel (no email)
Modified: 2010-10-22 23:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2010-10-22 23:07 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-22 23:03:27 PDT 
EWS never releases patches which fail to apply
Comment 1 Eric Seidel (no email) 2010-10-22 23:07:14 PDT 
Created attachment 71622 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-10-22 23:08:40 PDT 
This explains 10 of the 11 patches that the Qt-EWS is stuck chewing on (and countless others from other queues).

The /release-patch design is fragile.  We need to come up with a cleaner pattern through which to release patches.
Comment 3 Adam Barth 2010-10-22 23:32:52 PDT 
Comment on attachment 71622 [details]
Patch

i wish there was a more central place to put these calls to release_work_item.
Comment 4 Eric Seidel (no email) 2010-10-22 23:42:52 PDT 
There probably are.  We need to finish patching holes in the dam and then sit back and make a sane design out of all this. :)
Comment 5 Eric Seidel (no email) 2010-10-22 23:43:24 PDT 
We also need to split release_work_item into two methods:  remove_work_item and unlock_work_item (or similar names).
Comment 6 WebKit Commit Bot 2010-10-22 23:47:56 PDT 
Comment on attachment 71622 [details]
Patch

Clearing flags on attachment: 71622

Committed r70382: <http://trac.webkit.org/changeset/70382>
Comment 7 WebKit Commit Bot 2010-10-22 23:48:01 PDT 
All reviewed patches have been landed.  Closing bug.