Bug 48168 - WebP decoding hits ASSERT
Summary: WebP decoding hits ASSERT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-22 18:12 PDT by Adam Barth
Modified: 2010-10-23 17:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2010-10-22 18:19 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-10-22 18:12:19 PDT 
WebP decoding hits ASSERT
Comment 1 Adam Barth 2010-10-22 18:19:46 PDT 
Created attachment 71616 [details]
Patch
Comment 2 Andreas Kling 2010-10-23 03:38:00 PDT 
Comment on attachment 71616 [details]
Patch

LGTM.
Comment 3 Adam Barth 2010-10-23 09:34:13 PDT 
Comment on attachment 71616 [details]
Patch

Thanks.
Comment 4 WebKit Commit Bot 2010-10-23 09:48:14 PDT 
Comment on attachment 71616 [details]
Patch

Clearing flags on attachment: 71616

Committed r70392: <http://trac.webkit.org/changeset/70392>
Comment 5 WebKit Commit Bot 2010-10-23 09:48:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Pascal Massimino 2010-10-23 11:35:10 PDT 
(In reply to comment #5)
> All reviewed patches have been landed.  Closing bug.

thanks for fixing that Adam!
i'm a little worried that rgb.resize() is zero'ing the memory we are going to be
filling. Is it? If so, this is unneeded operation... But we can revisit that later.
Comment 7 Adam Barth 2010-10-23 17:19:56 PDT 
> i'm a little worried that rgb.resize() is zero'ing the memory we are going to be
> filling. Is it? If so, this is unneeded operation... But we can revisit that later.

We should look at the code an see.  There area a bunch of templates to unwind.  If it does, we can add a resizeUninitialized() function to vector.