RESOLVED FIXED 48168
WebP decoding hits ASSERT 
https://bugs.webkit.org/show_bug.cgi?id=48168
Summary WebP decoding hits ASSERT
Adam Barth
Reported 2010-10-22 18:12:19 PDT
WebP decoding hits ASSERT
Attachments
Patch (1.58 KB, patch)
2010-10-22 18:19 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-10-22 18:19:46 PDT
Created attachment 71616 [details] Patch
Andreas Kling
Comment 2 2010-10-23 03:38:00 PDT
Comment on attachment 71616 [details] Patch LGTM.
Adam Barth
Comment 3 2010-10-23 09:34:13 PDT
Comment on attachment 71616 [details] Patch Thanks.
WebKit Commit Bot
Comment 4 2010-10-23 09:48:14 PDT
Comment on attachment 71616 [details] Patch Clearing flags on attachment: 71616 Committed r70392: <http://trac.webkit.org/changeset/70392>
WebKit Commit Bot
Comment 5 2010-10-23 09:48:19 PDT
All reviewed patches have been landed. Closing bug.
Pascal Massimino
Comment 6 2010-10-23 11:35:10 PDT
(In reply to comment #5) > All reviewed patches have been landed. Closing bug. thanks for fixing that Adam! i'm a little worried that rgb.resize() is zero'ing the memory we are going to be filling. Is it? If so, this is unneeded operation... But we can revisit that later.
Adam Barth
Comment 7 2010-10-23 17:19:56 PDT
> i'm a little worried that rgb.resize() is zero'ing the memory we are going to be > filling. Is it? If so, this is unneeded operation... But we can revisit that later. We should look at the code an see. There area a bunch of templates to unwind. If it does, we can add a resizeUninitialized() function to vector.
Note You need to log in before you can comment on or make changes to this bug.