Bug 48165 - commit-queue should not pass --quiet to subcommands now that the parent command does the reporting
Summary: commit-queue should not pass --quiet to subcommands now that the parent comma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-22 17:13 PDT by Eric Seidel (no email)
Modified: 2010-10-22 17:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (17.53 KB, patch)
2010-10-22 17:15 PDT, Eric Seidel (no email)
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-22 17:13:51 PDT
commit-queue should not pass --quiet to subcommands now that the parent command does the reporting
Comment 1 Eric Seidel (no email) 2010-10-22 17:15:21 PDT
Created attachment 71614 [details]
Patch
Comment 2 Adam Barth 2010-10-22 17:16:23 PDT
Comment on attachment 71614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71614&action=review

Ok.  Are we going to run out of disk space?  :)

> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:144
> +        # Unclear if this should pass --quiet or not.  If --parent-command always does the reporting, than it should.

than => then
Comment 3 Eric Seidel (no email) 2010-10-22 17:38:14 PDT
I'm more worried that we'll spam the commit-queue's logs, or that we'll hang queues due to pipe full errors (but that should really already be handled by executive.py correctly).

I suspect we may end up moving off of run_and_throw_if_fail here now that we don't need to watch the queue's live anymore.
Comment 4 Eric Seidel (no email) 2010-10-22 17:41:27 PDT
Committed r70374: <http://trac.webkit.org/changeset/70374>