Bug 48155 - Fix assert when a NetscapePluginModule loses its last NetscapePlugin.
Summary: Fix assert when a NetscapePluginModule loses its last NetscapePlugin.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-22 14:42 PDT by Anders Carlsson
Modified: 2010-10-22 15:16 PDT (History)
0 users

See Also:

Attachments
Patch (3.67 KB, patch)
2010-10-22 14:44 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-10-22 14:42:19 PDT 
Fix assert when a NetscapePluginModule loses its last NetscapePlugin.
Comment 1 Anders Carlsson 2010-10-22 14:44:33 PDT 
Created attachment 71596 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-10-22 14:47:52 PDT 
Comment on attachment 71596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71596&action=review

> WebKit2/ChangeLog:16
> +        Set m_sInitialized to false.

Typo: m_sInitialized.

Can you make a test?

It would be nice to say what assertion was failing and when. Then we'll have a hope of reproducing this in the future if we need to.
Comment 3 Anders Carlsson 2010-10-22 14:50:29 PDT 
(In reply to comment #2)
> (From update of attachment 71596 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71596&action=review
> 
> > WebKit2/ChangeLog:16
> > +        Set m_sInitialized to false.
> 
> Typo: m_sInitialized.
> 
> Can you make a test?

This is already tested in LayoutTests/plugins.

> It would be nice to say what assertion was failing and when. Then we'll have a hope of reproducing this in the future if we need to.

Sure!
Comment 4 Anders Carlsson 2010-10-22 15:16:41 PDT 
Committed r70347: <http://trac.webkit.org/changeset/70347>