Bug 48152 - Implement copyTextureToParentTextureCHROMIUM in WebGraphicsContext3DDefaultImpl.
Summary: Implement copyTextureToParentTextureCHROMIUM in WebGraphicsContext3DDefaultImpl.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
: 47289 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-10-22 13:56 PDT by Stephen White
Modified: 2010-11-02 07:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.53 KB, patch)
2010-10-22 14:02 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (6.90 KB, patch)
2010-10-25 07:44 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (7.10 KB, patch)
2010-10-26 09:47 PDT, Stephen White 		kbr: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-10-22 13:56:30 PDT 
Implement copyTextureToParentTextureCHROMIUM in WebGraphicsContext3DDefaultImpl.
Comment 1 Stephen White 2010-10-22 14:02:30 PDT 
Created attachment 71593 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-10-24 01:26:43 PDT 
Attachment 71593 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4708053
Comment 3 WebKit Review Bot 2010-10-24 11:21:02 PDT 
Attachment 71593 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4624071
Comment 4 Stephen White 2010-10-25 07:44:49 PDT 
Created attachment 71747 [details]
Patch
Comment 5 Stephen White 2010-10-25 13:10:24 PDT 
Fix for warning-as-error on chromium/linux, and add chromium DEPS roll to pick up new API.
Comment 6 Kenneth Russell 2010-10-25 19:27:37 PDT 
Comment on attachment 71747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71747&action=review

This basically looks good but one issue.

> WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:580
> +    glGetTexLevelParameteriv(GL_TEXTURE_2D, 0, GL_TEXTURE_WIDTH, &width);

Please guard this call either with a call to gfx::GetGLImplementation() (app/gfx/gl/gl_implementation.h) or a test of whether glGetTexLevelParameteriv is NULL. Actually, in the current structure, supportsCopyTextureToParentTextureCHROMIUM should return false if this function is not available. This should prevent crashes when running on ANGLE or a pure GLES2 implementation. See https://bugs.webkit.org/show_bug.cgi?id=48282 .
Comment 7 Stephen White 2010-10-26 09:47:25 PDT 
Created attachment 71902 [details]
Patch
Comment 8 Kenneth Russell 2010-10-26 10:32:50 PDT 
Comment on attachment 71902 [details]
Patch

Looks good.
Comment 9 Stephen White 2010-10-26 12:01:50 PDT 
Committed r70552: <http://trac.webkit.org/changeset/70552>
Comment 10 Stephen White 2010-11-02 07:09:33 PDT 
*** Bug 47289 has been marked as a duplicate of this bug. ***