Bug 48150 - [Mac] LayoutTests/fast/events/spatial-navigation/snav-single-select.html hangs
Summary: [Mac] LayoutTests/fast/events/spatial-navigation/snav-single-select.html hangs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks: 46905
  Show dependency treegraph
 
Reported: 2010-10-22 13:21 PDT by Chang Shu
Modified: 2010-11-17 08:48 PST (History)
2 users (show)

See Also:


Attachments
fix patch (4.77 KB, patch)
2010-11-09 08:38 PST, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2010-10-22 13:21:17 PDT
The above test hangs on Mac. For some reason, a visible graphic popup shows up during the DRT testing and it waits for input.
Comment 1 Chang Shu 2010-11-09 08:38:23 PST
Created attachment 73381 [details]
fix patch

Here is basically what I did in this patch:
When ARROW_KEYS_POP_MENU is defined, which is the case on Mac, do up/down key pop menu only when spatial navigation is not enabled. And when spatial navigation is enabled, do the work flow as if ARROW_KEYS_POP_MENU is not defined so that selecting items is allowed.
Comment 2 WebKit Commit Bot 2010-11-17 08:48:38 PST
Comment on attachment 73381 [details]
fix patch

Clearing flags on attachment: 73381

Committed r72210: <http://trac.webkit.org/changeset/72210>
Comment 3 WebKit Commit Bot 2010-11-17 08:48:44 PST
All reviewed patches have been landed.  Closing bug.