RESOLVED FIXED 48149
Update block direction overflow for lines to be writing-mode-aware. 
https://bugs.webkit.org/show_bug.cgi?id=48149
Summary Update block direction overflow for lines to be writing-mode-aware.
Dave Hyatt
Reported 2010-10-22 13:05:27 PDT
Update block direction overflow for lines to be writing-mode-aware.
Attachments
Patch (18.51 KB, patch)
2010-10-22 13:07 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-10-22 13:07:20 PDT
Created attachment 71589 [details] Patch
Sam Weinig
Comment 2 2010-10-22 13:10:21 PDT
Comment on attachment 71589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71589&action=review > WebCore/rendering/style/RenderStyle.h:644 > + void getTextShadowBlockDirectionExtent(int& logicalTop, int & logicalBottom) { getShadowBlockDirectionExtent(textShadow(), logicalTop, logicalBottom); } Weird spacing around the &. > WebCore/rendering/style/RenderStyle.h:664 > + void getBoxShadowBlockDirectionExtent(int& logicalTop, int & logicalBottom) { getShadowBlockDirectionExtent(boxShadow(), logicalTop, logicalBottom); } Here too.
Dave Hyatt
Comment 3 2010-10-22 13:29:47 PDT
Fixed in r70330.
WebKit Review Bot
Comment 4 2010-10-22 14:15:11 PDT
http://trac.webkit.org/changeset/70330 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/forms/basic-textareas-quirks.html fast/forms/basic-textareas.html platform/mac/scrollbars/key-window-not-first-responder.html scrollbars/overflow-scrollbar-combinations.html
Dave Hyatt
Comment 5 2010-10-22 15:12:38 PDT
Silly mistake. Will land fix shortly.
Note You need to log in before you can comment on or make changes to this bug.