Bug 48149 - Update block direction overflow for lines to be writing-mode-aware.
Summary: Update block direction overflow for lines to be writing-mode-aware.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency treegraph
 
Reported: 2010-10-22 13:05 PDT by Dave Hyatt
Modified: 2010-10-22 15:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (18.51 KB, patch)
2010-10-22 13:07 PDT, Dave Hyatt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-22 13:05:27 PDT
Update block direction overflow for lines to be writing-mode-aware.
Comment 1 Dave Hyatt 2010-10-22 13:07:20 PDT
Created attachment 71589 [details]
Patch
Comment 2 Sam Weinig 2010-10-22 13:10:21 PDT
Comment on attachment 71589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71589&action=review

> WebCore/rendering/style/RenderStyle.h:644
> +    void getTextShadowBlockDirectionExtent(int& logicalTop, int & logicalBottom) { getShadowBlockDirectionExtent(textShadow(), logicalTop, logicalBottom); }

Weird spacing around the &.

> WebCore/rendering/style/RenderStyle.h:664
> +    void getBoxShadowBlockDirectionExtent(int& logicalTop, int & logicalBottom) { getShadowBlockDirectionExtent(boxShadow(), logicalTop, logicalBottom); }

Here too.
Comment 3 Dave Hyatt 2010-10-22 13:29:47 PDT
Fixed in r70330.
Comment 4 WebKit Review Bot 2010-10-22 14:15:11 PDT
http://trac.webkit.org/changeset/70330 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
fast/forms/basic-textareas-quirks.html
fast/forms/basic-textareas.html
platform/mac/scrollbars/key-window-not-first-responder.html
scrollbars/overflow-scrollbar-combinations.html
Comment 5 Dave Hyatt 2010-10-22 15:12:38 PDT
Silly mistake.  Will land fix shortly.