There are a couple of issues in the GObject binding generator: * webkit_dom_html_input_element_get_files is not included in the conditional methods * conditional methods that are part of the API should not be conditionally built. Instead, the implementation of those methods must be enclosed by #if ENABLE() clauses * Conditional methods with return type different than void, whose implementation is not meant to be built, does not currently have a return statement.
Created attachment 71573 [details] Fixes to the code generator
Comment on attachment 71573 [details] Fixes to the code generator I'm a bit confused, what's the point of having the two sets of #if in the cbody? Shouldn't you only leave the one inside the function body and get rid of the one outside?
(In reply to comment #2) > (From update of attachment 71573 [details]) > I'm a bit confused, what's the point of having the two sets of #if in the cbody? Shouldn't you only leave the one inside the function body and get rid of the one outside? Yeah right, I just changed the conditionals. I left both because I somehow thought that there could be public methods of those classes that wouldn't be part of WEBKIT_API but it seems that indeed it's not the case.
Created attachment 71725 [details] Fixes to the GObject code generator New version of the patch. Removed the wrapping ifdef's and the conditionalMethods hack
Comment on attachment 71725 [details] Fixes to the GObject code generator Looks good to me.
Comment on attachment 71725 [details] Fixes to the GObject code generator Clearing flags on attachment: 71725 Committed r70844: <http://trac.webkit.org/changeset/70844>
All reviewed patches have been landed. Closing bug.