Bug 48125 - Further preparations to deploy the new SVGAnimatedProperty concept for the rest of the SVG datatypes
Summary: Further preparations to deploy the new SVGAnimatedProperty concept for the re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 47905
  Show dependency tree / graph
 
Reported: 2010-10-22 05:30 PDT by Nikolas Zimmermann
Modified: 2010-10-22 06:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch (21.56 KB, patch)
2010-10-22 05:33 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch v2 (21.77 KB, patch)
2010-10-22 06:13 PDT, Nikolas Zimmermann 		krit: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-10-22 05:30:03 PDT 
SVGListPropertyTearOff & friends need some futher tweaks, to allow more datatypes to use them.
Comment 1 Nikolas Zimmermann 2010-10-22 05:33:29 PDT 
Created attachment 71554 [details]
Patch
Comment 2 Nikolas Zimmermann 2010-10-22 06:13:17 PDT 
Created attachment 71557 [details]
Patch v2

Ouch, forgot the destructor. SVGPropertyTearOff does it right, SVGListPropertyTearOff also needs to delete m_values if m_valuesIsCopy=true.
The code is yet unused, when I convert SVGStringList to use this new code, I would have noticed it on a leaks run...
Comment 3 Dirk Schulze 2010-10-22 06:25:12 PDT 
Comment on attachment 71557 [details]
Patch v2

LGTM. r=me
Comment 4 Nikolas Zimmermann 2010-10-22 06:26:58 PDT 
Landed in r70303.