Bug 48121 - Web Inspector: update resources tree in storage panel upon network events.
Summary: Web Inspector: update resources tree in storage panel upon network events.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-22 04:10 PDT by Pavel Feldman
Modified: 2010-10-22 06:33 PDT (History)
11 users (show)

See Also:


Attachments
[PATCH] Proposed change. (18.94 KB, patch)
2010-10-22 04:12 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-10-22 04:10:55 PDT
We now have live frame tree with resources no matter whether resource tracking is on or off.
Comment 1 Pavel Feldman 2010-10-22 04:12:36 PDT
Created attachment 71546 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2010-10-22 04:53:25 PDT
Comment on attachment 71546 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=71546&action=review

> WebCore/inspector/InspectorResourceAgent.cpp:354
> +    frameObject->setNumber("parentId", reinterpret_cast<uintptr_t>(frame->tree()->parent()));

can we extract this reinterpret_cast into a function that would convert to the id for us?

> WebCore/inspector/front-end/StoragePanel.js:187
> +                    (child._resource.type !== WebInspector.Resource.Type.Document && child._resource.displayName.localeCompare(resource.displayName) > 0)) {

style: wrong alignment
Comment 3 Pavel Feldman 2010-10-22 05:20:33 PDT
(In reply to comment #2)
> (From update of attachment 71546 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71546&action=review
> 
> > WebCore/inspector/InspectorResourceAgent.cpp:354
> > +    frameObject->setNumber("parentId", reinterpret_cast<uintptr_t>(frame->tree()->parent()));
> 
> can we extract this reinterpret_cast into a function that would convert to the id for us?
> 

Will fix in the next patch.
Comment 4 WebKit Commit Bot 2010-10-22 06:33:28 PDT
Comment on attachment 71546 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 71546

Committed r70305: <http://trac.webkit.org/changeset/70305>
Comment 5 WebKit Commit Bot 2010-10-22 06:33:33 PDT
All reviewed patches have been landed.  Closing bug.