Bug 48118 – [WINCE] Implement EditorClient::handleKeyboardEvent

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 71541 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 71541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71541&action=review

> WebKit/wince/WebCoreSupport/EditorClientWinCE.cpp:339
> +        for (unsigned i = 0; i < _countof(keyDownEntries); i++)
> +            keyDownCommandsMap->set(keyDownEntries[i].modifiers << 16 | keyDownEntries[i].virtualKey, keyDownEntries[i].name);
> +
> +        for (unsigned i = 0; i < _countof(keyPressEntries); i++)
> +            keyPressCommandsMap->set(keyPressEntries[i].modifiers << 16 | keyPressEntries[i].charCode, keyPressEntries[i].name);
> +    }
> +
> +    unsigned modifiers = 0;
> +    if (event->shiftKey())
> +        modifiers |= ShiftKey;
> +    if (event->altKey())
> +        modifiers |= AltKey;
> +    if (event->ctrlKey())
> +        modifiers |= CtrlKey;
> +
> +    if (event->type() == eventNames().keydownEvent) {
> +        int mapKey = modifiers << 16 | event->keyCode();
> +        return mapKey ? keyDownCommandsMap->get(mapKey) : 0;
> +    }
> +
> +    int mapKey = modifiers << 16 | event->charCode();
> +    return mapKey ? keyPressCommandsMap->get(mapKey) : 0;
> +}
> +

It would be nice if we had a function to take (modifiers, key/charCode) and turn it into a HashMap key.

[WebKit Commit Bot]

Comment on attachment 71541 [details]
Patch

Clearing flags on attachment: 71541

Committed r70313: <http://trac.webkit.org/changeset/70313>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.