RESOLVED FIXED 48111
Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111
Summary Remove Android build system
Adam Barth
Reported 2010-10-21 21:54:48 PDT
Remove Android build system
Attachments
Patch (52.60 KB, patch)
2010-10-21 21:59 PDT, Adam Barth
no flags
Patch (144.16 KB, patch)
2011-04-27 03:35 PDT, Steve Block
no flags
Adam Barth
Comment 1 2010-10-21 21:59:03 PDT
WebKit Commit Bot
Comment 2 2010-10-21 22:34:53 PDT
Comment on attachment 71525 [details] Patch Clearing flags on attachment: 71525 Committed r70290: <http://trac.webkit.org/changeset/70290>
WebKit Commit Bot
Comment 3 2010-10-21 22:34:58 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 4 2010-10-21 22:38:43 PDT
Dimitri points out that I probably should have checked with you folk before posting this patch. I was kind of expecting it to get more discussion before landing. As far as I can tell, these files were pretty far out of date and presumably the Android port is using some other build system. I think it'd be great to have a way of building the Android port, but we'll probably need at least on build slave building the port for it to stay working.
David Levin
Comment 5 2010-10-21 22:40:55 PDT
(In reply to comment #4) > Dimitri points out that I probably should have checked with you folk before posting this patch. I was kind of expecting it to get more discussion before landing. > > As far as I can tell, these files were pretty far out of date and presumably the Android port is using some other build system. I think it'd be great to have a way of building the Android port, but we'll probably need at least on build slave building the port for it to stay working. fwiw, I'd gladly r+ a patch to add them back as well if anyone promised to keep them up to date.
Steve Block
Comment 6 2010-10-22 03:46:21 PDT
> As far as I can tell, these files were pretty far out of date and presumably > the Android port is using some other build system. Yes, these files are slightly out of date, but our build system does still use them. Android WebKit is pretty forked from upstream, but we do take regular merges. These build files are pretty well maintained by people adding or removing source files upstream and these changes do help us in performing our merges. > I think it'd be great to have a way of building the Android port, but we'll probably need at least on > build slave building the port for it to stay working. Absolutely. As you know, we are making an effort to upstream Android WebKit. However, it has proven to be a far more time consuming process than we initially envisaged, which is how these build files have ended up getting out of sync. Apologies for that. I can send a patch to reinstate these files and to bring them up to date. We'll also make more of an effort to keep them as up to date as possible, given our current state of forking. Note that if we were to remove these files, there are more Android build files at WebCore/Android.*.mk which should probably be removed too. I'm surprised that this patch was landed with no consultation of those working on Android. My understanding is that WebKit policy is to not make significant changes to other platform's code without prior discussion. benm@google.com, andreip@google.com or myself would be good points of contact for Android WebKit in the future.
David Levin
Comment 7 2010-10-22 05:41:44 PDT
(In reply to comment #6) > I'm surprised that this patch was landed with no consultation of those > working on Android. Apologies. It was my mistake. Please revert this change.
Adam Barth
Comment 8 2010-10-22 10:54:44 PDT
Reverted r70290 for reason: Undelete Android build files. Committed r70318: <http://trac.webkit.org/changeset/70318>
Steve Block
Comment 9 2011-04-27 03:35:01 PDT
David Levin
Comment 10 2011-04-27 07:17:27 PDT
Comment on attachment 91262 [details] Patch Second times a charm?
WebKit Commit Bot
Comment 11 2011-04-27 09:50:52 PDT
Comment on attachment 91262 [details] Patch Clearing flags on attachment: 91262 Committed r85058: <http://trac.webkit.org/changeset/85058>
WebKit Commit Bot
Comment 12 2011-04-27 09:50:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.