Bug 48111 – Remove Android build system

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Remove Android build system

[Adam Barth]

Created attachment 71525 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 71525 [details]
Patch

Clearing flags on attachment: 71525

Committed r70290: <http://trac.webkit.org/changeset/70290>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

Dimitri points out that I probably should have checked with you folk before posting this patch.  I was kind of expecting it to get more discussion before landing.

As far as I can tell, these files were pretty far out of date and presumably the Android port is using some other build system.  I think it'd be great to have a way of building the Android port, but we'll probably need at least on build slave building the port for it to stay working.

[David Levin]

(In reply to comment #4)
> Dimitri points out that I probably should have checked with you folk before posting this patch.  I was kind of expecting it to get more discussion before landing.
> 
> As far as I can tell, these files were pretty far out of date and presumably the Android port is using some other build system.  I think it'd be great to have a way of building the Android port, but we'll probably need at least on build slave building the port for it to stay working.

fwiw, I'd gladly r+ a patch to add them back as well if anyone promised to keep them up to date.

[Steve Block]

> As far as I can tell, these files were pretty far out of date and presumably
> the Android port is using some other build system.
Yes, these files are slightly out of date, but our build system does
still use them.

Android WebKit is pretty forked from upstream, but we do take regular
merges. These build files are pretty well maintained by people adding or
removing source files upstream and these changes do help us in performing
our merges.

> I think it'd be great to have a way of building the Android port, but we'll probably need at least on
> build slave building the port for it to stay working.
Absolutely. As you know, we are making an effort to upstream Android
WebKit. However, it has proven to be a far more time consuming process
than we initially envisaged, which is how these build files have ended
up getting out of sync. Apologies for that.

I can send a patch to reinstate these files and to bring them up to date.
We'll also make more of an effort to keep them as up to date as possible,
given our current state of forking. Note that if we were to remove these
files, there are more Android build files at WebCore/Android.*.mk which
should probably be removed too.

I'm surprised that this patch was landed with no consultation of those
working on Android. My understanding is that WebKit policy is to not
make significant changes to other platform's code without prior
discussion. [e-mail], [e-mail] or myself would be good
points of contact for Android WebKit in the future.

[David Levin]

(In reply to comment #6)
> I'm surprised that this patch was landed with no consultation of those
> working on Android. 

Apologies. It was my mistake. Please revert this change.

[Adam Barth]

Reverted r70290 for reason:

Undelete Android build files.

Committed r70318: <http://trac.webkit.org/changeset/70318>

[Steve Block]

Created attachment 91262 [details]
Patch

[David Levin]

Comment on attachment 91262 [details]
Patch

Second times a charm?

[WebKit Commit Bot]

Comment on attachment 91262 [details]
Patch

Clearing flags on attachment: 91262

Committed r85058: <http://trac.webkit.org/changeset/85058>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.