Bug 48099 - [GTK] Menu list buttons do not react properly to CSS styling
Summary: [GTK] Menu list buttons do not react properly to CSS styling
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2010-10-21 16:27 PDT by Martin Robinson
Modified: 2010-10-23 10:10 PDT (History)
3 users (show)

See Also:

Patch for this issue (90.49 KB, patch)
2010-10-21 17:53 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-10-21 16:27:06 PDT
There are a couple issues with menu list buttons. The first is that they ignore many important CSS properties like width, height, and padding. In particular, the GTK+ values override any padding set on the widget.

The second issue is that when certain CSS properties are set, WebKit falls back rendering via calls to adjustMenuListButtonStyle and paintMenuListButton (versus adjustMenuListStyle and paintMenuList). This distinction is for the benefit of the Mac port, which tries to render Aqua-themed controls whenever possible.

At the current time, we always render GTK+-themed controls, so we can ignore the split and implement both similarly.
Comment 1 Martin Robinson 2010-10-21 17:53:11 PDT
Created attachment 71516 [details]
Patch for this issue
Comment 2 Xan Lopez 2010-10-22 06:00:30 PDT
Comment on attachment 71516 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=71516&action=review

Seems sensible.

> WebCore/ChangeLog:5
> +        [GTK] Menu list buttons do react properly to CSS styling

Is there a 'not' missing here or am I missing something?
Comment 3 Martin Robinson 2010-10-23 08:29:46 PDT
Comment on attachment 71516 [details]
Patch for this issue

Clearing flags on attachment: 71516

Committed r70391: <http://trac.webkit.org/changeset/70391>
Comment 4 Martin Robinson 2010-10-23 08:29:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-10-23 10:10:40 PDT
http://trac.webkit.org/changeset/70391 might have broken GTK Linux 64-bit Debug
The following tests are not passing: