Bug 48098 – Metadata queries should return full file info, not just modification time

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Eric U.]

This is needed for WorkerAsyncFileWriterChromium's constructor, will enable cleanup of AsyncFileWriterChromium's constructor, and may be useful in a number of places in the future.

[Eric U.]

Created attachment 71579 [details]
Patch

[Kinuko Yasuda]

Comment on attachment 71579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71579&action=review

> WebCore/platform/AsyncFileSystemCallbacks.h:53
> +    virtual void didReadMetadata(const FileMetadata&) = 0;

If we hook this change at this layer I think we should place FileMetadata under platform.
Then we'll have fileapi/Metadata for a DOM object and platform/FileMetata for internal bookkeeping.

...or I guess even we could put it in platform/FileSystem.h.  What do you think?

[WebKit Review Bot]

Attachment 71579 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4701064

[Eric U.]

Comment on attachment 71579 [details]
Patch

Will fix on Monday.
Kinuko, let's talk in person about your suggestion; I'm still learning what's supposed to go in which directory.  Thanks!

[Eric U.]

Created attachment 71830 [details]
Patch

[Eric U.]

(In reply to comment #4)
> (From update of attachment 71579 [details])
> Will fix on Monday.
> Kinuko, let's talk in person about your suggestion; I'm still learning what's supposed to go in which directory.  Thanks!

Moved as per your recommendation.

[Eric U.]

Thanks David; would you also CQ+ or land?  Thanks!

[WebKit Commit Bot]

Comment on attachment 71830 [details]
Patch

Rejecting patch 71830 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 71830]" exit_code: 2
Last 500 characters of output:
ium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/src/AssertMatchingEnums.cpp
Hunk #1 FAILED at 37.
Hunk #2 FAILED at 57.
Hunk #3 succeeded at 365 with fuzz 2 (offset 2 lines).
2 out of 3 hunks FAILED -- saving rejects to file WebKit/chromium/src/AssertMatchingEnums.cpp.rej
patching file WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4823044

[Eric U.]

Created attachment 72123 [details]
Patch

[Eric U.]

Comment on attachment 72123 [details]
Patch

This is just a rebasing of the patch David reviewed.  He asked me to post it, marked as reviewed by him, and get a committer to CQ+ it for me.

[WebKit Review Bot]

Comment on attachment 72123 [details]
Patch

Rejecting patch 72123 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Eric U.]

Created attachment 72132 [details]
Patch

[Dumitru Daniliuc]

Comment on attachment 72132 [details]
Patch

> After restart the commit-queue will correctly respect your reviewer rights.

respect my authoritah!

rs=me, based on dave's r+.

[WebKit Commit Bot]

Comment on attachment 72132 [details]
Patch

Clearing flags on attachment: 72132

Committed r70745: <http://trac.webkit.org/changeset/70745>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.