Bug 48092 - Crash evaluating JavaScript string that throws an exception
Summary: Crash evaluating JavaScript string that throws an exception
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
Keywords: InRadar
Depends on:
Reported: 2010-10-21 14:33 PDT by Anders Carlsson
Modified: 2010-10-21 14:48 PDT (History)
0 users

See Also:

Patch (10.02 KB, patch)
2010-10-21 14:37 PDT, Anders Carlsson
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-10-21 14:33:01 PDT
Crash evaluating JavaScript string that throws an exception
Comment 1 Anders Carlsson 2010-10-21 14:36:00 PDT
Comment 2 Anders Carlsson 2010-10-21 14:37:22 PDT
Created attachment 71495 [details]
Comment 3 Adam Roben (:aroben) 2010-10-21 14:40:06 PDT
Comment on attachment 71495 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=71495&action=review

> WebKitTools/ChangeLog:15
> +        (TestWebKitAPI::TEST):

I've been replacing this line with TestWebKitAPI::WebKit2_EvaluateJavaScript (e.g.).

> WebKitTools/TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:42
> +    // FIXME: We should also check the error, but right now it's always null.

Maybe you should TEST_ASSERT that it is null. Then we will have something reminding us we need to update this test when we make it be non-null!
Comment 4 Anders Carlsson 2010-10-21 14:48:08 PDT
Committed r70267: <http://trac.webkit.org/changeset/70267>