Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
Created attachment 71475 [details]
For example, when uploading this patch, this is the output:
% webkit-patch upload --suggest-reviewers --request-commit Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog
Total errors found: 0 in 8 files
Using editor in the CHANGE_LOG_EDIT_APPLICATION environment variable.
Please quit the editor application when done editing.
Was that diff correct? [Y/n]:
The following reviewers have recently modified files in your patch:
Would you like to CC them? [Y/n]:
Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue...
Logging in as email@example.com...
Adding ['firstname.lastname@example.org', 'email@example.com', 'firstname.lastname@example.org', 'email@example.com', 'firstname.lastname@example.org', 'email@example.com'] to the CC list for bug 48088
Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=48088
We'll definitely want to refine this further, but as-is this is *hugely* useful to me when uploading patches. I hope it's useful to others.
Comment on attachment 71475 [details]
Donde esta la stepe?
Created attachment 71488 [details]
Comment on attachment 71488 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=71488&action=review
Also, it should work for post!
> + reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit)
You're not passing in the set of changed_files.
> + reviewer_emails = [reviewer.bugzilla_email() for reviewer in reviewers]
You can use map for this if you like.
Created attachment 71490 [details]
Comment on attachment 71490 [details]
Clearing flags on attachment: 71490
Committed r70274: <http://trac.webkit.org/changeset/70274>
All reviewed patches have been landed. Closing bug.