Bug 48088 - Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
Summary: Add --suggest-reviewers option to upload to auto-suggest reviewers for your p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-21 12:43 PDT by Eric Seidel (no email)
Modified: 2010-10-21 16:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.13 KB, patch)
2010-10-21 12:51 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (15.58 KB, patch)
2010-10-21 14:06 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (16.16 KB, patch)
2010-10-21 14:15 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-21 12:43:49 PDT 
Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
Comment 1 Eric Seidel (no email) 2010-10-21 12:51:35 PDT 
Created attachment 71475 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-10-21 12:52:37 PDT 
For example, when uploading this patch, this is the output:

% webkit-patch upload --suggest-reviewers --request-commit                                                                             Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog
Running check-webkit-style
Total errors found: 0 in 8 files
Using editor in the CHANGE_LOG_EDIT_APPLICATION environment variable.
Please quit the editor application when done editing.
Was that diff correct? [Y/n]: 
Fetching: https://bugs.webkit.org/show_bug.cgi?id=48088&ctype=xml
The following reviewers have recently modified files in your patch:
Adam Barth
Chris Jerdonek
Daniel Bates
David Levin
Eric Seidel
Ojan Vafai
Would you like to CC them? [Y/n]: 
Reading Keychain for bugs.webkit.org account and password.  Click "Allow" to continue...
Logging in as eric@webkit.org...
Adding ['abarth@webkit.org', 'cjerdonek@webkit.org', 'dbates@webkit.org', 'levin@chromium.org', 'eric@webkit.org', 'ojan@chromium.org'] to the CC list for bug 48088
Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=48088
Comment 3 Eric Seidel (no email) 2010-10-21 12:53:14 PDT 
We'll definitely want to refine this further, but as-is this is *hugely* useful to me when uploading patches.  I hope it's useful to others.
Comment 4 Adam Barth 2010-10-21 14:02:49 PDT 
Comment on attachment 71475 [details]
Patch

Donde esta la stepe?
Comment 5 Eric Seidel (no email) 2010-10-21 14:06:05 PDT 
Created attachment 71488 [details]
Patch
Comment 6 Adam Barth 2010-10-21 14:07:55 PDT 
Comment on attachment 71488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71488&action=review

Also, it should work for post!

> WebKitTools/Scripts/webkitpy/tool/steps/suggestreviewers.py:45
> +        reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit)

You're not passing in the set of changed_files.

> WebKitTools/Scripts/webkitpy/tool/steps/suggestreviewers.py:50
> +        reviewer_emails = [reviewer.bugzilla_email() for reviewer in reviewers]

You can use map for this if you like.
Comment 7 Eric Seidel (no email) 2010-10-21 14:15:05 PDT 
Created attachment 71490 [details]
Patch
Comment 8 WebKit Commit Bot 2010-10-21 16:00:56 PDT 
Comment on attachment 71490 [details]
Patch

Clearing flags on attachment: 71490

Committed r70274: <http://trac.webkit.org/changeset/70274>
Comment 9 WebKit Commit Bot 2010-10-21 16:01:02 PDT 
All reviewed patches have been landed.  Closing bug.