Bug 48070 - [Qt] When doing rendering through tiling, it seems the tiles are not initialized before rendering
Summary: [Qt] When doing rendering through tiling, it seems the tiles are not initiali...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-21 08:29 PDT by Benjamin Poulain
Modified: 2010-10-21 13:31 PDT (History)
5 users (show)

See Also:


Attachments
Simple application showing the issue (429 bytes, text/plain)
2010-10-21 08:29 PDT, Benjamin Poulain
no flags Details
Patch (3.24 KB, patch)
2010-10-21 10:17 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (3.24 KB, patch)
2010-10-21 11:48 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-10-21 08:29:43 PDT
Created attachment 71441 [details]
Simple application showing the issue

When a page is not defining a background color, the rendering of the background is incorect when tiling is used.

The attached file show a page not rendered correctly when tiling is enabled.
Comment 1 Noam Rosenthal 2010-10-21 10:17:27 PDT
Created attachment 71453 [details]
Patch
Comment 2 Noam Rosenthal 2010-10-21 11:48:26 PDT
Created attachment 71465 [details]
Patch

Right now it's too complicated to autotest TBS. it's a whole different task that's mutually exclusive from this fix.
Comment 3 Simon Hausmann 2010-10-21 13:06:27 PDT
Comment on attachment 71465 [details]
Patch

Good catch. One more of these cases where QPixmap's lack of default-initialization bites us somewhat.
Comment 4 WebKit Commit Bot 2010-10-21 13:31:28 PDT
Comment on attachment 71465 [details]
Patch

Clearing flags on attachment: 71465

Committed r70262: <http://trac.webkit.org/changeset/70262>
Comment 5 WebKit Commit Bot 2010-10-21 13:31:33 PDT
All reviewed patches have been landed.  Closing bug.