Bug 48062 - Add cmn to branch32(reg, imm) on ARM
Summary: Add cmn to branch32(reg, imm) on ARM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-21 04:21 PDT by Gabor Loki
Modified: 2010-10-27 06:48 PDT (History)
2 users (show)

See Also:


Attachments
Add cmn to branch32(reg, imm) on ARM (1.99 KB, patch)
2010-10-21 04:25 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-10-21 04:21:29 PDT
There is a missing optimization in the branch32(cond, reg, imm) function on ARM. The conditional comparison can be done with cmn if the imm value is negative and can fit into the cmn instruction.
Comment 1 Gabor Loki 2010-10-21 04:25:10 PDT
Created attachment 71423 [details]
Add cmn to branch32(reg, imm) on ARM
Comment 2 WebKit Commit Bot 2010-10-27 06:48:23 PDT
Comment on attachment 71423 [details]
Add cmn to branch32(reg, imm) on ARM

Clearing flags on attachment: 71423

Committed r70642: <http://trac.webkit.org/changeset/70642>
Comment 3 WebKit Commit Bot 2010-10-27 06:48:28 PDT
All reviewed patches have been landed.  Closing bug.