NEW 48041
`webkit-patch upload` runs git-diff at least 3 times, which is slow 
https://bugs.webkit.org/show_bug.cgi?id=48041
Summary `webkit-patch upload` runs git-diff at least 3 times, which is slow
Adam Roben (:aroben)
Reported 2010-10-20 22:36:58 PDT
`webkit-patch upload` runs git-diff at least 3 times: 1) when finding ChangeLogs to parse for bug IDs 2) when running check-webkit-style (I think) 3) when creating the diff to present to the user for confirmation There might be other instances of git-diff that I've missed. It would be faster if we could just run git-diff once.
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-10-20 22:46:08 PDT
Yeah, I recently removed one of them (by sharing the one for prepare-ChangeLog with another one we do). We should be able to remove the one for check-webkit-style by passing it the list of changed files. However, passing them today gives you different output. We need to teach check-webkit-style to diff a set of files provided on the command line. It's not that much code.
Eric Seidel (no email)
Comment 2 2010-10-21 08:17:22 PDT
I'm pretty sure we have another bug on this somewhere...
Eric Seidel (no email)
Comment 3 2010-10-21 08:18:12 PDT
See bug 39207.
Note You need to log in before you can comment on or make changes to this bug.