Bug 48033 - Remove the destructors of Safari's DatabaseTracker clients on Windows and Mac
Summary: Remove the destructors of Safari's DatabaseTracker clients on Windows and Mac
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-20 17:46 PDT by Dumitru Daniliuc
Modified: 2010-10-21 11:54 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-10-20 17:46:25 PDT 
WebKit/win/WebDatabaseManager.h and WebKit/mac/Storage/WebDatabaseTrackerClient.h should have destructor declarations, but should not implement them, since they're supposed to be singletons that are never destroyed.
Comment 1 Anders Carlsson 2010-10-21 09:27:19 PDT 
Maybe we should add a WTF macro for declaring a class as not being destructable. On C++0x compilers we could then use = delete, just like we do for WTF_MAKE_NONCOPYABLE.
Comment 2 Darin Adler 2010-10-21 11:44:55 PDT 
(In reply to comment #1)
> Maybe we should add a WTF macro for declaring a class as not being destructable. On C++0x compilers we could then use = delete, just like we do for WTF_MAKE_NONCOPYABLE.

I think we should do that.
Comment 3 Anders Carlsson 2010-10-21 11:49:31 PDT 
(In reply to comment #2)
> I think we should do that.

WTF_MAKE_NONDESTRUCTABLE? WTF_MAKE_INDESTRUCTABLE? :)
Comment 4 Darin Adler 2010-10-21 11:54:25 PDT 
WTF_MAKE_NONDESTRUCTIBLE would be a good name.