WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
48033
Remove the destructors of Safari's DatabaseTracker clients on Windows and Mac
https://bugs.webkit.org/show_bug.cgi?id=48033
Summary
Remove the destructors of Safari's DatabaseTracker clients on Windows and Mac
Dumitru Daniliuc
Reported
2010-10-20 17:46:25 PDT
WebKit/win/WebDatabaseManager.h and WebKit/mac/Storage/WebDatabaseTrackerClient.h should have destructor declarations, but should not implement them, since they're supposed to be singletons that are never destroyed.
Attachments
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-10-21 09:27:19 PDT
Maybe we should add a WTF macro for declaring a class as not being destructable. On C++0x compilers we could then use = delete, just like we do for WTF_MAKE_NONCOPYABLE.
Darin Adler
Comment 2
2010-10-21 11:44:55 PDT
(In reply to
comment #1
)
> Maybe we should add a WTF macro for declaring a class as not being destructable. On C++0x compilers we could then use = delete, just like we do for WTF_MAKE_NONCOPYABLE.
I think we should do that.
Anders Carlsson
Comment 3
2010-10-21 11:49:31 PDT
(In reply to
comment #2
)
> I think we should do that.
WTF_MAKE_NONDESTRUCTABLE? WTF_MAKE_INDESTRUCTABLE? :)
Darin Adler
Comment 4
2010-10-21 11:54:25 PDT
WTF_MAKE_NONDESTRUCTIBLE would be a good name.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug