Bug 48025 - [Chromium] Remove chromium baseline for http/tests/plugins/geturlnotify-from-npp-destroystream.html
Summary: [Chromium] Remove chromium baseline for http/tests/plugins/geturlnotify-from-...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julie Parent
Depends on:
Reported: 2010-10-20 16:33 PDT by Julie Parent
Modified: 2010-10-21 15:17 PDT (History)
2 users (show)

See Also:

Patch (84.73 KB, patch)
2010-10-20 16:52 PDT, Julie Parent
no flags Details | Formatted Diff | Diff
Patch (2.26 KB, patch)
2010-10-20 16:58 PDT, Julie Parent
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2010-10-20 16:33:36 PDT
Currently, this test:
Is skipped on Mac
Passes ~100% on Linux
Fails ~100% on Win

The chromium baseline is the mac baseline + a console error message.  Win is failing because it matches the upstream expectation, aka, it does not print out an error.  Linux passes because it does have the error.

Matching upstream expectation and updating test_expectations for new failures seems correct, rather than adding a linux baseline with the error message.
Comment 1 Tony Chang 2010-10-20 16:51:13 PDT
FWIW, I'm trying to switch to using the webkit.org test plugin.  I've already made the switch for chromium DRT mac, so it would be good to know if this test passes with chromium DRT mac.
Comment 2 Julie Parent 2010-10-20 16:52:45 PDT
Created attachment 71364 [details]
Comment 3 Julie Parent 2010-10-20 16:53:35 PDT
Comment on attachment 71364 [details]

Not sure what happened with ChangeLog there.  Fixing.
Comment 4 Julie Parent 2010-10-20 16:58:45 PDT
Created attachment 71368 [details]
Comment 5 Julie Parent 2010-10-20 17:01:22 PDT
I don't have a Mac, but I could try unskipping in test_expectations and see what happens?  I don't see a good reason for this to be skipped anyway.
Comment 6 Tony Chang 2010-10-20 17:11:51 PDT
Comment on attachment 71368 [details]

Deleting the wrong baseline seems fine.  It would be good to try to unskip this test on Mac, but that can be a separate change.
Comment 7 WebKit Commit Bot 2010-10-21 15:16:42 PDT
The commit-queue encountered the following flaky tests while processing attachment 71368 [details]:


Please file bugs against the tests.  The author(s) of the test(s) are ap@webkit.org and ap@webkit.org.  The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2010-10-21 15:17:43 PDT
Comment on attachment 71368 [details]

Clearing flags on attachment: 71368

Committed r70271: <http://trac.webkit.org/changeset/70271>
Comment 9 WebKit Commit Bot 2010-10-21 15:17:49 PDT
All reviewed patches have been landed.  Closing bug.