Bug 48024 - Composited elements drawn twice when WebView is layer-backed
Summary: Composited elements drawn twice when WebView is layer-backed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-10-20 16:29 PDT by Simon Fraser (smfr)
Modified: 2010-10-20 18:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.86 KB, patch)
2010-10-20 16:33 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (4.83 KB, patch)
2010-10-20 17:31 PDT, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-10-20 16:29:41 PDT 
If the WebView is layer backed (via -setWantsLayer:YES), then there are issues with the rendering of composited content. It draws twice.
Comment 1 Simon Fraser (smfr) 2010-10-20 16:30:04 PDT 
<rdar://problem/7916580>
Comment 2 Simon Fraser (smfr) 2010-10-20 16:33:19 PDT 
Created attachment 71358 [details]
Patch
Comment 3 mitz 2010-10-20 17:08:22 PDT 
Comment on attachment 71358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71358&action=review

> WebKit/mac/WebView/WebFrame.mm:532
> +- (BOOL)_showFlattenedCompositingLayers:(CGContextRef)context

This name is no good. This method doesn’t show anything.

> WebKit/mac/WebView/WebFrame.mm:540
> +    if (WKCGContextIsBitmapContext(context)) {

Can reverse the test and return early here.
Comment 4 Simon Fraser (smfr) 2010-10-20 17:31:11 PDT 
Created attachment 71371 [details]
Patch
Comment 5 Simon Fraser (smfr) 2010-10-20 18:18:02 PDT 
http://trac.webkit.org/changeset/70199