Bug 48015 - Add Git-support to do-file-rename
Summary: Add Git-support to do-file-rename
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-20 15:34 PDT by Daniel Bates
Modified: 2010-10-21 14:22 PDT (History)
0 users

See Also:

Attachments
Patch (3.61 KB, patch)
2010-10-20 15:46 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-10-20 15:34:29 PDT 
Currently, do-file-rename is hard coded to only work with SVN when renaming files that match the replacement criterion. Instead, we should abstract the SCM move/rename command into a common function in VCSUtils since this functionality is used by both do-file-rename and do-webcore-rename.
Comment 1 Daniel Bates 2010-10-20 15:46:03 PDT 
Created attachment 71349 [details]
Patch

Add an SCM-independent move/rename function to VCSUtils.pm that can is used by both do-file-rename and do-webcore-rename.
Comment 2 Martin Robinson 2010-10-20 15:51:54 PDT 
Comment on attachment 71349 [details]
Patch

Looks good!
Comment 3 Daniel Bates 2010-10-20 15:54:48 PDT 
Comment on attachment 71349 [details]
Patch

Clearing flags on attachment: 71349

Committed r70187: <http://trac.webkit.org/changeset/70187>
Comment 4 Daniel Bates 2010-10-20 15:54:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Daniel Bates 2010-10-21 14:22:54 PDT 
I inadvertently left out the line to export the function scmMoveOrRenameFile() in the patch. Committed fix in changeset 70264 <http://trac.webkit.org/changeset/70264>.