Bug 48013 – [Qt] Add findAllSelectedElements and findFirstSelectedElement functions to QWebFrame

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit Qt

[Dawit A.]

This enhancement is intended to make it possible to search for elements ONLY in the user-selected portions of a web page.

[Dawit A.]

Created attachment 71347 [details]
proposed patch

[Dawit A.]

Created attachment 71474 [details]
proposed patch [update #1]

[Dawit A.]

Created attachment 71570 [details]
proposed patch [update #2]

let see if this solves the patch apply failure...

[Benjamin Poulain]

I am really, really not a fan of the API. This is just abusing QWebElement, which is already causing us problems because it does not handle text.

Personally, I think we should not try to solve selection before solving https://bugs.webkit.org/show_bug.cgi?id=31099

When we have a good way to access elements and text, then we can create a new class to handle selection.

[Benjamin Poulain]

Comment on attachment 71570 [details]
proposed patch [update #2]

I r- for now. I think this is the wrong solution to the problem. You can start the discussion on the mailing list.

[Dawit A.]

Yes, I actually meant to withdraw this request, but completely forgot about it. Besides the solution I came up with here being very ugly and hacky, QWebElement itself has more than few limitations and at least one severe bug in the underlying code (read: webkit) which has already forced me to stop using it in kdewebkit to parse for forms on a page.

Anyhow, I will withdraw this request and close the ticket.