Bug 48005 - chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
Summary: chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-20 13:47 PDT by Kenneth Russell
Modified: 2010-10-20 14:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2010-10-20 13:48 PDT, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-10-20 13:47:09 PDT 
The normal Chromium port of new-run-webkit-tests, when run on Linux, searches first the Linux directory for test expectations and then the Windows directory. The chromium-gpu port needs to do the same within the scope of the chromium-gpu directories.
Comment 1 Kenneth Russell 2010-10-20 13:48:39 PDT 
Created attachment 71333 [details]
Patch
Comment 2 James Robinson 2010-10-20 13:50:57 PDT 
So on chromium linux with gpu it'll go:

chromium-gpu-linux
chromium-gpu-win
chromium-gpu
chromium-linux
chromium-win
chromium
mac
(alongside test)

?
Comment 3 Kenneth Russell 2010-10-20 13:53:51 PDT 
(In reply to comment #2)
> So on chromium linux with gpu it'll go:
> 
> chromium-gpu-linux
> chromium-gpu-win
> chromium-gpu
> chromium-linux
> chromium-win
> chromium
> mac
> (alongside test)
> 
> ?

Yes, that's right. Dirk and I discussed this last night and this is the intended and desired behavior.
Comment 4 Kenneth Russell 2010-10-20 13:54:57 PDT 
Committed r70175: <http://trac.webkit.org/changeset/70175>
Comment 5 Dirk Pranke 2010-10-20 14:06:13 PDT 
Comment on attachment 71333 [details]
Patch

change looks good to me, although I'm not a reviewer.
Comment 6 WebKit Review Bot 2010-10-20 14:36:08 PDT 
http://trac.webkit.org/changeset/70175 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/xmlhttprequest/origin-whitelisting-removal.html