WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
47984
Web Inspector: lastActivePanel things were refactored.
https://bugs.webkit.org/show_bug.cgi?id=47984
Summary
Web Inspector: lastActivePanel things were refactored.
Ilya Tikhonovsky
Reported
2010-10-20 06:37:07 PDT
It'd be nice to split lastActivePanel into two separate entities. The first one is the front-end setting lastActivePanel which is the part of WebInspector.applicationSettings. The second is the name of panel which should be opened at front-end after its load. The second entity is required if the isn't opened yet. This is the typical situation when the user uses Safari's shortcuts like Show Error Console, Start Debugging Javascript, InspectElement, etc.
Attachments
[patch] initial version.
(18.24 KB, patch)
2010-10-20 06:48 PDT
,
Ilya Tikhonovsky
pfeldman
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2010-10-20 06:48:16 PDT
Created
attachment 71287
[details]
[patch] initial version. All InspectorState.h was changed because it had DOS encoding for line-end. Really lastActivePanel was removed from the property list and showPanel was added.
Pavel Feldman
Comment 2
2010-10-20 07:12:11 PDT
Comment on
attachment 71287
[details]
[patch] initial version. View in context:
https://bugs.webkit.org/attachment.cgi?id=71287&action=review
> WebCore/inspector/InspectorController.cpp:277 > + m_state->setString(InspectorState::showPanel, ElementsPanel);
1. This is not inspector's state 2. You should not mirror it to the front-end
Pavel Feldman
Comment 3
2011-02-08 08:08:12 PST
Closing obsolete bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug