WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47979
Do not have two different asCell APIs in JSValue
https://bugs.webkit.org/show_bug.cgi?id=47979
Summary
Do not have two different asCell APIs in JSValue
Xan Lopez
Reported
2010-10-20 05:47:29 PDT
We have both JSCell* JSValue::asCell() and JSCell* asCell(JSValue value). Attached patch gets rid of the latter as suggested by FIXME.
Attachments
ascell.diff
(18.47 KB, patch)
2010-10-20 05:49 PDT
,
Xan Lopez
no flags
Details
Formatted Diff
Diff
ascell.diff
(18.56 KB, patch)
2010-10-20 06:02 PDT
,
Xan Lopez
no flags
Details
Formatted Diff
Diff
ascell.diff
(24.51 KB, patch)
2010-10-20 06:25 PDT
,
Xan Lopez
no flags
Details
Formatted Diff
Diff
ascell.diff
(24.51 KB, patch)
2010-10-20 06:51 PDT
,
Xan Lopez
no flags
Details
Formatted Diff
Diff
ascell.diff
(24.51 KB, patch)
2010-10-20 07:45 PDT
,
Xan Lopez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Xan Lopez
Comment 1
2010-10-20 05:49:23 PDT
Created
attachment 71277
[details]
ascell.diff
WebKit Review Bot
Comment 2
2010-10-20 05:53:32 PDT
Attachment 71277
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/jit/JITStubs.cpp:2909: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] JavaScriptCore/jit/JITStubs.cpp:2915: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Xan Lopez
Comment 3
2010-10-20 06:02:49 PDT
Created
attachment 71279
[details]
ascell.diff Fix style warnings. They were already there, but since we are touching the code...
Xan Lopez
Comment 4
2010-10-20 06:25:06 PDT
Created
attachment 71281
[details]
ascell.diff Fix interpreter bits.
Xan Lopez
Comment 5
2010-10-20 06:51:04 PDT
Created
attachment 71288
[details]
ascell.diff
Xan Lopez
Comment 6
2010-10-20 07:45:41 PDT
Created
attachment 71293
[details]
ascell.diff Trying to upload the correct patch...
Oliver Hunt
Comment 7
2010-10-27 13:30:39 PDT
Comment on
attachment 71293
[details]
ascell.diff r=me
Xan Lopez
Comment 8
2010-10-28 00:02:01 PDT
Comment on
attachment 71293
[details]
ascell.diff Landed as
r70749
.
Xan Lopez
Comment 9
2010-10-28 00:02:14 PDT
Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug