Bug 47973 - Rename SVGAnimatedProperty* -> DeprecatedSVGAnimatedProperty*
Summary: Rename SVGAnimatedProperty* -> DeprecatedSVGAnimatedProperty*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 47905
  Show dependency tree / graph
 
Reported: 2010-10-20 00:31 PDT by Nikolas Zimmermann
Modified: 2010-10-20 14:41 PDT (History)
7 users (show)

See Also:

Attachments
Patch (102.53 KB, patch)
2010-10-20 00:39 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch v2 (102.51 KB, patch)
2010-10-20 01:07 PDT, Nikolas Zimmermann 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-10-20 00:31:29 PDT 
To prepare fixing bug 47905, mark the existing animated property concept deprecated.
Comment 1 Nikolas Zimmermann 2010-10-20 00:39:17 PDT 
Created attachment 71259 [details]
Patch
Comment 2 Nikolas Zimmermann 2010-10-20 01:07:58 PDT 
Created attachment 71263 [details]
Patch v2

Let's see if it applies this time *sigh*. I just reverted the SVGAnimatedPropertySynchronizer move, and started again by doing:
mkdir properties; svn add properties; svn mv SVGAnimatedPropertySynchronizer.h properties;

Not sure why it did not work before...
Comment 3 Nikolas Zimmermann 2010-10-20 01:33:20 PDT 
Thanks. Landed in r70135.
Comment 4 Nikolas Zimmermann 2010-10-20 02:15:51 PDT 
Landed qt/gtk/win build fix (missing svg/property include directory) in r70136.
Fix Qt/WebKit2 build in r70138.
Comment 5 Nikolas Zimmermann 2010-10-20 02:19:20 PDT 
Fix efl build in r70139.
Comment 6 Nikolas Zimmermann 2010-10-20 02:44:05 PDT 
(In reply to comment #5)
> Fix efl build in r70139.
WebCore builds. Fix WebKit efl build in r70142.
Comment 7 Andrey Kosyakov 2010-10-20 10:47:23 PDT 
This apparently broke clobbered build on win due to 
DeprecatedSVGAnimatedProperty.h:25:#include "SVGAnimatedPropertySynchronizer.h"

The latter include moved under properties subdir, which is not copied to WebKitBuild/include/WebCore. You may want to update
WebKit/WebCore/WebCore.vcproj/copyForwardingHeaders.cmd 

The incremental build apparently works due to https://webkit.org/b/46638
Comment 8 Nikolas Zimmermann 2010-10-20 13:28:52 PDT 
(In reply to comment #7)
> This apparently broke clobbered build on win due to 
> DeprecatedSVGAnimatedProperty.h:25:#include "SVGAnimatedPropertySynchronizer.h"
> 
> The latter include moved under properties subdir, which is not copied to WebKitBuild/include/WebCore. You may want to update
> WebKit/WebCore/WebCore.vcproj/copyForwardingHeaders.cmd 
> 
> The incremental build apparently works due to https://webkit.org/b/46638

Thanks for the note, landed a fix in r70168.
Comment 9 WebKit Review Bot 2010-10-20 14:41:13 PDT 
http://trac.webkit.org/changeset/70168 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/backgrounds/repeat/negative-offset-repeat-transformed.html
fast/borders/border-image-rotate-transform.html
fast/borders/border-image-scale-transform.html
fast/transforms/scrollIntoView-transformed.html
transforms/2d/hindi-rotated.html