Bug 47966 - fast/css/long-css-selector-matches.html test causes TIMEOUT in some platforms
Summary: fast/css/long-css-selector-matches.html test causes TIMEOUT in some platforms
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-19 22:44 PDT by Hayato Ito
Modified: 2023-07-09 17:03 PDT (History)
0 users

See Also:


Attachments
make-depth-level-smaller (2.54 KB, patch)
2010-10-19 23:23 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2010-10-19 22:44:29 PDT
The objective of fast/css/long-css-selector-matches.html test is whether stack overflow happens or not if a long css selector is used.
To make stack overflow happen in old implementation of CSSStyleSelector, we had to increase a CSS selector's depth level at some level. But that increases a execution time of that test.

So we have a dilemma.

The more and more we increate a depth level, stack overflow becomes to happen more likely in bad implementation, but a timeout of test becomes to happen more likely in some platforms.
In fact, the test in chromium in test_shell causes TIMEOUT, so we had to mark that test 'PASS TIMEOUT' in chromium/test_expectations.txt: https://trac.webkit.org/changeset/70123.

It is not ideal situation that marking it 'PASS TIMEOUT' in only some platforms.
We have to come to compromise about a depth level so that it doesn't cause TIMEOUT.
Comment 1 Hayato Ito 2010-10-19 23:23:20 PDT
Created attachment 71254 [details]
make-depth-level-smaller
Comment 2 Hayato Ito 2010-10-20 00:11:29 PDT
Hi reviewers,
if you have any suggestions about how to deal this test, any opinions are welcome.

I am not pretty sure that making a depth level smaller is a good idea.
Comment 3 Hayato Ito 2010-10-21 19:34:51 PDT
Comment on attachment 71254 [details]
make-depth-level-smaller

I've cleared the review flag because the original change was reverted in
http://trac.webkit.org/changeset/70209