Bug 47960 - ASSERTION FAILURE: !m_adoptionIsRequired for the WebFrame under the InjectedBundlePageLoaderClient::didClearWindowObjectForFrame callback
Summary: ASSERTION FAILURE: !m_adoptionIsRequired for the WebFrame under the InjectedB...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-19 18:04 PDT by Jessie Berlin
Modified: 2010-10-20 14:35 PDT (History)
6 users (show)

See Also:


Attachments
Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor (1.90 KB, patch)
2010-10-19 18:11 PDT, Jessie Berlin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2010-10-19 18:04:22 PDT
frame->init() in the WebFrame constructor causes the InjectedBundlePageLoaderClient::didClearWindowObjectForFrame callback to be called with a reference to the WebFrame (at which point the WebFrame has not yet been adopted).

We should fix this by moving the frame->init() call into the WebFrame::create method.
Comment 1 Jessie Berlin 2010-10-19 18:11:26 PDT
Created attachment 71238 [details]
Move initializing the coreFrame into the  WebFrame create method and out of the WebFrame constructor
Comment 2 Geoffrey Garen 2010-10-20 08:21:16 PDT
Comment on attachment 71238 [details]
Move initializing the coreFrame into the  WebFrame create method and out of the WebFrame constructor

r=me
Comment 3 Jessie Berlin 2010-10-20 08:32:23 PDT
Comment on attachment 71238 [details]
Move initializing the coreFrame into the  WebFrame create method and out of the WebFrame constructor

Committed in r70148
http://trac.webkit.org/changeset/70148
Comment 4 WebKit Review Bot 2010-10-20 09:26:38 PDT
http://trac.webkit.org/changeset/70148 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
fast/workers/storage/interrupt-database-sync.html
Comment 5 Jessie Berlin 2010-10-20 09:34:52 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/70148 might have broken Leopard Intel Release (Tests)
> The following tests are not passing:
> fast/workers/storage/interrupt-database-sync.html

Pretty unlikely, as we don't build WebKit2 stuff on Leopard.
Comment 6 WebKit Review Bot 2010-10-20 14:35:50 PDT
http://trac.webkit.org/changeset/70173 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/xmlhttprequest/origin-whitelisting-removal.html