Bug 47943 - Teach feeder-queue how to feed the EWS bots
Summary: Teach feeder-queue how to feed the EWS bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 35460
  Show dependency tree / graph
 
Reported: 2010-10-19 16:11 PDT by Eric Seidel (no email)
Modified: 2010-10-19 18:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch (12.28 KB, patch)
2010-10-19 16:14 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-19 16:11:59 PDT 
Teach feeder-queue how to feed the EWS bots
Comment 1 Eric Seidel (no email) 2010-10-19 16:14:21 PDT 
Created attachment 71218 [details]
Patch
Comment 2 Adam Barth 2010-10-19 18:03:40 PDT 
Comment on attachment 71218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71218&action=review

yay!

> WebKitTools/Scripts/webkitpy/tool/bot/feeders.py:80
> +        self._ids_sent_to_server = set()
> +        AbstractFeeder.__init__(self, tool)

I'd reverse these lines.
Comment 3 WebKit Commit Bot 2010-10-19 18:26:38 PDT 
Comment on attachment 71218 [details]
Patch

Clearing flags on attachment: 71218

Committed r70117: <http://trac.webkit.org/changeset/70117>
Comment 4 WebKit Commit Bot 2010-10-19 18:26:43 PDT 
All reviewed patches have been landed.  Closing bug.