Bug 47933 - navigator.language doesn't work in WebKit2
Summary: navigator.language doesn't work in WebKit2
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2010-10-19 14:47 PDT by Alexey Proskuryakov
Modified: 2010-10-19 15:29 PDT (History)
0 users

See Also:

proposed patch (62.79 KB, patch)
2010-10-19 15:15 PDT, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-10-19 14:47:58 PDT
It should!
Comment 1 Alexey Proskuryakov 2010-10-19 14:49:28 PDT
Mac is somewhat special in that there is a way to override language per application (or even per an instance of an application). This means that we should only be looking at the language in UI process.
Comment 2 Alexey Proskuryakov 2010-10-19 14:49:42 PDT
Comment 3 Alexey Proskuryakov 2010-10-19 15:15:48 PDT
Created attachment 71208 [details]
proposed patch
Comment 4 Anders Carlsson 2010-10-19 15:18:56 PDT
Comment on attachment 71208 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71208&action=review

> WebCore/platform/mac/Language.mm:95
> +            preferredLanguageCode = [@"en" retain];

No need to retain a constant string.
Comment 5 Alexey Proskuryakov 2010-10-19 15:29:22 PDT
Committed <http://trac.webkit.org/changeset/70095>.