WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47933
navigator.language doesn't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=47933
Summary
navigator.language doesn't work in WebKit2
Alexey Proskuryakov
Reported
2010-10-19 14:47:58 PDT
It should!
Attachments
proposed patch
(62.79 KB, patch)
2010-10-19 15:15 PDT
,
Alexey Proskuryakov
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2010-10-19 14:49:28 PDT
Mac is somewhat special in that there is a way to override language per application (or even per an instance of an application). This means that we should only be looking at the language in UI process.
Alexey Proskuryakov
Comment 2
2010-10-19 14:49:42 PDT
<
rdar://problem/8494337
>
Alexey Proskuryakov
Comment 3
2010-10-19 15:15:48 PDT
Created
attachment 71208
[details]
proposed patch
Anders Carlsson
Comment 4
2010-10-19 15:18:56 PDT
Comment on
attachment 71208
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=71208&action=review
> WebCore/platform/mac/Language.mm:95 > + preferredLanguageCode = [@"en" retain];
No need to retain a constant string.
Alexey Proskuryakov
Comment 5
2010-10-19 15:29:22 PDT
Committed <
http://trac.webkit.org/changeset/70095
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug