Bug 47920 - BytecodeGenerator::m_lastOpcodePosition must be initialized in all constructors
Summary: BytecodeGenerator::m_lastOpcodePosition must be initialized in all constructors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45457
  Show dependency treegraph
 
Reported: 2010-10-19 12:41 PDT by Csaba Osztrogonác
Modified: 2010-10-19 14:49 PDT (History)
2 users (show)

See Also:


Attachments
proposed fix (1.52 KB, patch)
2010-10-19 12:42 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-10-19 12:41:41 PDT
BytecodeGenerator has two constructors which
don't initialize m_lastOpcodePosition.

Details: https://bugs.webkit.org/show_bug.cgi?id=45457
Comment 1 Csaba Osztrogonác 2010-10-19 12:42:51 PDT
Created attachment 71193 [details]
proposed fix
Comment 2 Geoffrey Garen 2010-10-19 12:49:08 PDT
Comment on attachment 71193 [details]
proposed fix

r=me
Comment 3 WebKit Commit Bot 2010-10-19 13:55:48 PDT
Comment on attachment 71193 [details]
proposed fix

Rejecting patch 71193 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71193]" exit_code: 2
Cleaning working directory
Updating working directory
Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2

Full output: http://queues.webkit.org/results/4533003
Comment 4 Csaba Osztrogonác 2010-10-19 14:42:37 PDT
Comment on attachment 71193 [details]
proposed fix

Clearing flags on attachment: 71193

Committed r70090: <http://trac.webkit.org/changeset/70090>
Comment 5 Csaba Osztrogonác 2010-10-19 14:42:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Adam Barth 2010-10-19 14:49:44 PDT
Adam's machine's checkout was wedged (eseidel)