Bug 47913 - [chromium] Disable mipmapping of ImageLayer's to conserve CPU and VRAM
Summary: [chromium] Disable mipmapping of ImageLayer's to conserve CPU and VRAM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-19 11:00 PDT by Vangelis Kokkevis
Modified: 2010-10-19 12:39 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (6.79 KB, patch)
2010-10-19 11:11 PDT, Vangelis Kokkevis
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-10-19 11:00:16 PDT
Mipmapping for ImageLayers was enabled with:

https://bugs.webkit.org/show_bug.cgi?id=46493

However, it turns out that a lot of regular HTML content makes no use of mipmap levels since images are drawn untransformed and in their source resolution.  In addition, mipmaping seems to have tickled an ANGLE bug:  

http://code.google.com/p/chromium/issues/detail?id=59426

A possible alternative solution once the ANGLE bug is resolved would be to turn on mipmapping only for layers that are displayed at a smaller size that would make effective use of the gpu.
Comment 1 Vangelis Kokkevis 2010-10-19 11:11:12 PDT
Created attachment 71187 [details]
proposed patch
Comment 2 Kenneth Russell 2010-10-19 11:14:29 PDT
Comment on attachment 71187 [details]
proposed patch

Verified that this patch is a reversion of the earlier one.
Comment 3 Vangelis Kokkevis 2010-10-19 12:39:14 PDT
Committed r70075: <http://trac.webkit.org/changeset/70075>