Bug 47911 – Add DirectX SDK to Installing Developer Tools web page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Jenn Braithwaite]

From a thread on webkit-dev:

date	Tue, Nov 24, 2009 at 7:39 AM
subject	[webkit-dev] New requirement for building on Windows coming

I've submitted a patch for accelerated compositing support on Windows. I hope to land it today. When I do it will require d3d9.lib to link. The feature will be turned off at first, but the build still needs to find the library. So the build-bots will need to be updated with DirectX 9.0 SDK Update (December 2004):

       http://www.microsoft.com/downloads/details.aspx?FamilyId=4E825A37-0C94-4421-9EC8-156E52525D11&displaylang=en

You'll also need to add a path to this SDK in your MSDev Include and Library paths. The WebKit build-bots have already been updated, but external ones should make the changes in preparation.


========

DirectX SDK is apparently now required to build on Windows.  webkit.org info needs to be updated to reflect this.

[Jenn Braithwaite]

Created attachment 71182 [details]
patch

[Eric Seidel (no email)]

Comment on attachment 71182 [details]
patch

OK.

[Eric Seidel (no email)]

CCing the windows folks.

[WebKit Commit Bot]

Comment on attachment 71182 [details]
patch

Rejecting patch 71182 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 71182]" exit_code: 2
Last 500 characters of output:
?id=71182&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47911&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 71182 from bug 47911.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html

Full output: http://queues.webkit.org/results/4553004

[Jenn Braithwaite]

Created attachment 71206 [details]
updated patch with ChangeLog

Forgot to include ChangeLog in the previous patch.

[Adam Roben (:aroben)]

Comment on attachment 71206 [details]
updated patch with ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=71206&action=review

> WebKitSite/building/tools.html:63
> +<p> Verify MSVC|Tools|Options|Projects and Solutions|VC++ Directories has Include: <code>$(DXSDK_DIR)include</code> and Lib: <code>$(DXSDK_DIR)lib</code> 

1) $(DXSDK_DIR)lib isn't correct. It should be $(DXSDK_DIR)lib/x86.
2) This shouldn't be necessary. Our projects add these to the include/lib paths for you.

[Adam Roben (:aroben)]

But thanks for updating the instructions!

[Eric Seidel (no email)]

Comment on attachment 71182 [details]
patch

Cleared Eric Seidel's review+ from obsolete attachment 71182 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[WebKit Commit Bot]

Comment on attachment 71206 [details]
updated patch with ChangeLog

Clearing flags on attachment: 71206

Committed r70121: <http://trac.webkit.org/changeset/70121>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.