Bug 47900 - [Qt] WebKit2 menu list popup delegate
Summary: [Qt] WebKit2 menu list popup delegate
Status: RESOLVED DUPLICATE of bug 62191
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on: 47899
Blocks: 43428
  Show dependency treegraph
 
Reported: 2010-10-19 06:16 PDT by Luiz Agostini
Modified: 2011-08-05 12:30 PDT (History)
0 users

See Also:


Attachments
patch (7.49 KB, patch)
2010-10-19 06:43 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-10-19 06:16:30 PDT
Added support for menu list popup delegate using our platform plugin in WebKit2.
Comment 1 Luiz Agostini 2010-10-19 06:43:22 PDT
Created attachment 71160 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2010-10-19 06:47:35 PDT
Comment on attachment 71160 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71160&action=review

So with this patch it works with webkit1 and webkit2 without changes to the platform plugin?

> WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:39
> +    switch (m_items[idx].m_type)
> +    {

{ should be on the other line, no?

> WebKit2/UIProcess/qt/WebPopupMenuProxyQt.h:58
> +        SelectData() :m_multiple(false) { }

space around :
Comment 3 Luiz Agostini 2010-10-19 06:52:00 PDT
(In reply to comment #2)
> (From update of attachment 71160 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71160&action=review
> 
> So with this patch it works with webkit1 and webkit2 without changes to the platform plugin?

Yes. No change was needed in the platform plugin. In this patch I did not implement the fallback popup.

> 
> > WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:39
> > +    switch (m_items[idx].m_type)
> > +    {
> 
> { should be on the other line, no?
> 
> > WebKit2/UIProcess/qt/WebPopupMenuProxyQt.h:58
> > +        SelectData() :m_multiple(false) { }
> 
> space around :
Comment 4 Luiz Agostini 2011-08-05 12:30:26 PDT

*** This bug has been marked as a duplicate of bug 62191 ***