Bug 47900 – [Qt] WebKit2 menu list popup delegate

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit2

[Luiz Agostini]

Added support for menu list popup delegate using our platform plugin in WebKit2.

[Luiz Agostini]

Created attachment 71160 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 71160 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71160&action=review

So with this patch it works with webkit1 and webkit2 without changes to the platform plugin?

> WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:39
> +    switch (m_items[idx].m_type)
> +    {

{ should be on the other line, no?

> WebKit2/UIProcess/qt/WebPopupMenuProxyQt.h:58
> +        SelectData() :m_multiple(false) { }

space around :

[Luiz Agostini]

(In reply to comment #2)
> (From update of attachment 71160 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71160&action=review
> 
> So with this patch it works with webkit1 and webkit2 without changes to the platform plugin?

Yes. No change was needed in the platform plugin. In this patch I did not implement the fallback popup.

> 
> > WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:39
> > +    switch (m_items[idx].m_type)
> > +    {
> 
> { should be on the other line, no?
> 
> > WebKit2/UIProcess/qt/WebPopupMenuProxyQt.h:58
> > +        SelectData() :m_multiple(false) { }
> 
> space around :

[Luiz Agostini]

*** This bug has been marked as a duplicate of bug 62191 ***