Bug 47898 - [Qt] getImageData returns wrong data for non-0,0 source offset
Summary: [Qt] getImageData returns wrong data for non-0,0 source offset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-19 04:42 PDT by Andreas Kling
Modified: 2010-10-19 06:31 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (4.54 KB, patch)
2010-10-19 04:46 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-10-19 04:42:46 PDT
Our getImageData() is busted for any sourceRect offset that isn't (0,0)
Comment 1 Andreas Kling 2010-10-19 04:46:43 PDT
Created attachment 71153 [details]
Proposed patch
Comment 2 Andreas Kling 2010-10-19 05:46:10 PDT
Comment on attachment 71153 [details]
Proposed patch

Clearing flags on attachment: 71153

Committed r70050: <http://trac.webkit.org/changeset/70050>
Comment 3 Andreas Kling 2010-10-19 05:46:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-10-19 06:31:34 PDT
http://trac.webkit.org/changeset/70050 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
fast/canvas/canvas-getImageData-negative-source.html