Bug 47891 - Web Inspector: Uncaught TypeError when connection to WebSocket server is refused
Summary: Web Inspector: Uncaught TypeError when connection to WebSocket server is refused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-19 02:07 PDT by Yuta Kitamura
Modified: 2010-10-19 03:22 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2010-10-19 02:23 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2010-10-19 02:07:13 PDT 
The following error occurs in Resources panel when a connection to an WebSocket server is refused.

Chromium's stderr looks like:
"Uncaught TypeError: Cannot call method 'split' of undefined," source: chrome://devtools/DevTools.js (8852)
"Uncaught TypeError: Cannot call method 'escapeHTML' of undefined," source: chrome://devtools/DevTools.js (30523)

How to reproduce:
1. Start HTTP server for layout tests (run-webkit-httpd) but do NOT start the WebSocket server.
2. Start the browser, open Web Inspector, enable resource tracking, and go to <http://localhost:8000/websocket/tests/send.html>.
3. Observe the error.


This error occurs because resource.url is not set when an WebSocket is initialized.
Comment 1 Yuta Kitamura 2010-10-19 02:23:40 PDT 
Created attachment 71144 [details]
Patch
Comment 2 Fumitoshi Ukai 2010-10-19 02:29:33 PDT 
Comment on attachment 71144 [details]
Patch

LGTM
Comment 3 WebKit Commit Bot 2010-10-19 03:22:05 PDT 
Comment on attachment 71144 [details]
Patch

Clearing flags on attachment: 71144

Committed r70043: <http://trac.webkit.org/changeset/70043>
Comment 4 WebKit Commit Bot 2010-10-19 03:22:11 PDT 
All reviewed patches have been landed.  Closing bug.