WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
47887
Remove private: access level directive from WTF_MAKE_FAST_ALLOCATED macro
https://bugs.webkit.org/show_bug.cgi?id=47887
Summary
Remove private: access level directive from WTF_MAKE_FAST_ALLOCATED macro
Zoltan Horvath
Reported
2010-10-19 00:52:02 PDT
We should remove private directive from the end of the WTF_MAKE_FAST_ALLOCATED macro, because it can causes problems with structs. This solution isn't nice: struct a { WTF_MAKE_FAST_ALLOCATED public: int x; } Other way is to put the macro to the end of the struct: struct a { int x; WTF_MAKE_FAST_ALLOCATED } Or we can simply remove "private:" from the end of the macro. Almost every class contains access level directives explicitly, so removing shouldn't cause much problems.
Attachments
proposed patch
(1.08 KB, patch)
2010-10-19 00:53 PDT
,
Zoltan Horvath
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zoltan Horvath
Comment 1
2010-10-19 00:53:22 PDT
Created
attachment 71139
[details]
proposed patch
Zoltan Horvath
Comment 2
2010-11-22 01:29:48 PST
Comment on
attachment 71139
[details]
proposed patch I've chosen the first solution since it is unambiguous. Closing as invalid.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug