Bug 47887 - Remove private: access level directive from WTF_MAKE_FAST_ALLOCATED macro
Summary: Remove private: access level directive from WTF_MAKE_FAST_ALLOCATED macro
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Zoltan Horvath
Depends on: 42998
  Show dependency treegraph
Reported: 2010-10-19 00:52 PDT by Zoltan Horvath
Modified: 2010-11-22 01:29 PST (History)
2 users (show)

See Also:

proposed patch (1.08 KB, patch)
2010-10-19 00:53 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2010-10-19 00:52:02 PDT
We should remove private directive from the end of the WTF_MAKE_FAST_ALLOCATED macro, because it can causes problems with structs.

This solution isn't nice:

struct a {
    int x;

Other way is to put the macro to the end of the struct:

struct a {
    int x;

Or we can simply remove "private:" from the end of the macro.

Almost every class contains access level directives explicitly, so removing shouldn't cause much problems.
Comment 1 Zoltan Horvath 2010-10-19 00:53:22 PDT
Created attachment 71139 [details]
proposed patch
Comment 2 Zoltan Horvath 2010-11-22 01:29:48 PST
Comment on attachment 71139 [details]
proposed patch

I've chosen the first solution since it is unambiguous.
Closing as invalid.