CC authors of flaky tests when the commit-queue hits a flaky test
Created attachment 71118 [details]
Comment on attachment 71118 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=71118&action=review
Looks OK. Please consider my comments below.
> + def recent_commit_infos_for_files(self, paths):
Eventually we'll want some sort of lookback_limit=5 argument here.
> + test_paths = map(path_for_layout_test, flaky_tests)
> + commit_infos = self._tool.checkout().recent_commit_infos_for_files(test_paths)
> + authors = [commit_info.author().bugzilla_email() for commit_info in commit_infos if commit_info.author()]
I would have made this a helper function. authors = self._author_emails_for_tests(flaky_tests)
That would have cleaned up this function a little.
> + cc_explaination = " The author(s) of the test(s) have been CCed on this bug."
I'm not sure this really needs to be conditional, but I guess it's nice that it is. Is this condition tested? Why not use a ternary to set this?
Created attachment 71121 [details]
Patch for landing
Comment on attachment 71121 [details]
Patch for landing
Rejecting patch 71121 from commit-queue.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71121]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as firstname.lastname@example.org...
Processing 1 patch from 1 bug.
Processing patch 71121 from bug 47872.
Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Full output: http://queues.webkit.org/results/4432075
Created attachment 71122 [details]
Comment on attachment 71122 [details]
Clearing flags on attachment: 71122
Committed r70023: <http://trac.webkit.org/changeset/70023>
All reviewed patches have been landed. Closing bug.